add hackability to use_kwargs_dict#279
Draft
marii-moe wants to merge 1 commit intoAnswerDotAI:masterfrom
Draft
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support the 'val_'+kwargs here: fastai/fastai#3133
Idea is to allow a little bit of hack-ability to
use_kwargs_dictinstead of writing specialdelegatesfunction for my one off use case. Maybe not a good idea?_wrapis reproducing the behavior indelegates, didn't want to change the default behavior ofuse_kwargs_dict, as I am not very familiar with its usage._wrapallows the stacking of multipleuse_kwargs_dictordelegateswhen keep=True, otherwise they would error when**kwargsis removed by firstdelegates`use_kwargs_dict`. (tests should make this more clear).Mostly looking for guidance here on if this makes sense, or if I should try something else. Here is example usage for easy reference: