fix urlretrieve NameError by importing tempfile #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jph00
reviewed
Feb 2, 2026
seemab-yamin
force-pushed
the
fix-net-urlretrieve-tempfile-import
branch
from
48505bb to
efd37bf
Compare
Contributor
Author
|
@jph00 - Implemented the style fix. Thanks for your time. |
Contributor
|
Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
urlretrieveafterfrom fastcore.net import *fails inside the function withRoot cause:
tempfileis used but not imported in the module.Changes:
import tempfileto the top imports cell innbs/03b_net.ipynbnbdev-export→ clean diff infastcore/net.pyTested with
nbdev-test(passed).