Merge beta to main which fixes input dry logic, switches to actions, and removes strapping warning.#21
Merge beta to main which fixes input dry logic, switches to actions, and removes strapping warning.#21TrevorSchirmer merged 11 commits intomainfrom
Conversation
Change from depreciated service calls to new actions
Removes warning in yaml about using gpio9 as a strapping pin
Change from depreciated service calls to new actions
…-warning Removes warning in yaml about using gpio9 as a strapping pin
Should fix #18
undo previous yaml change
Fix input dry logic
WalkthroughUpdates ESPHome YAML: bumps version, renames API surface from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
update beta branch version
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Integrations/ESPHome/Core.yaml (1)
34-50: The migration fromservicestoactionsis correct and aligns with ESPHome's API evolution.ESPHome supports the updated
actionsterminology while maintaining backward compatibility withservicesin YAML for the foreseeable future. This is not a breaking change for Home Assistant users—existing automations usingserviceswill continue to work. Updating toactionsis a best practice following ESPHome's terminology alignment with Home Assistant, but not required.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Integrations/ESPHome/Core.yaml(5 hunks)
🔇 Additional comments (3)
Integrations/ESPHome/Core.yaml (3)
3-3: LGTM: Version bumpThe version update from 25.8.6.1 to 25.12.18.1 is appropriate for this release.
174-180: Verify boot behavior with GPIO9 as strapping pin.GPIO9 is a strapping pin on ESP32-C6 that affects boot mode. While
ignore_strapping_warning: truesuppresses the warning, ensure the pin's state during boot (with pullup enabled) doesn't interfere with normal startup or cause unintended boot modes.Consider testing the device through multiple power cycles and resets to confirm reliable boot behavior. The pullup configuration should keep the pin HIGH by default, which is typically safe, but verification is recommended.
370-376: Critical bug fix: Corrected input dry logic.This change fixes a critical logic error in the pump safety system. With
inverted: trueon thefluid_input_sensor(line 215), the sensor state is OFF when physically dry. The previousbinary_sensor.is_oncheck would have incorrectly stopped the pump when the input was wet, opposite of the intended behavior.The corrected logic now properly stops the pump when the input sensor is OFF (dry), which aligns with:
- The feature name "Stop Pump When Input Dry" (line 124)
- The on_turn_on condition that requires the sensor to be ON (wet) to start (line 150)
Excellent catch on fixing this safety-critical bug!
# Conflicts: # Integrations/ESPHome/Core.yaml
Version:
What does this implement/fix?
Merge beta to main which fixes input dry logic, switches to actions, and removes strapping warning.
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.