Open
Conversation
mahichr
previously approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new features, primarily focusing on improving configuration management, error handling, and Kubernetes integration. The most significant changes include the addition of a configuration management system, enhanced error handling in commands, and updates to Kubernetes namespace handling. Below is a detailed breakdown of the changes by theme:
Configuration Management
ConfigManagerclass to handle loading, saving, and ensuring configuration, including prompting for a Tenant GUID and opening a browser for account creation if necessary (cli/src/Vdk/Services/ConfigManager.cs).VdkConfigmodel to represent configuration data such asTenantIdand environment (cli/src/Vdk/Services/ConfigManager.cs).Kubernetes Integration
KubernetesConfigMapHelperto create aConfigMapfor storing cluster information (cli/src/Vdk/Services/KubernetesConfigMapHelper.cs).ReverseProxyClientto handle thevega-systemnamespace instead ofvega, including creating or updating aConfigMapfor cluster information after Flux bootstrap (cli/src/Vdk/Services/ReverseProxyClient.cs). [1] [2] [3] [4]Error Handling Enhancements
try-catchblocks with error logging in theInvokeAsyncmethods ofCreateRegistryCommand,RemoveRegistryCommand, andRemoveProxyCommandto handle exceptions gracefully (cli/src/Vdk/Commands/CreateRegistryCommand.cs,cli/src/Vdk/Commands/RemoveRegistryCommand.cs,cli/src/Vdk/Commands/RemoveProxyCommand.cs). [1] [2] [3]Command Improvements
CreateClusterCommandandInitializeCommandto ensure configuration exists before proceeding, using the newConfigManager(cli/src/Vdk/Commands/CreateClusterCommand.cs,cli/src/Vdk/Commands/InitializeCommand.cs). [1] [2]CreateClusterCommandto accept aFunc<string, IKubernetesClient>for dynamic Kubernetes client creation (cli/src/Vdk/Commands/CreateClusterCommand.cs).Testing Infrastructure
CommandTestBaseclass with mock support forIConsoleto simplify unit testing for commands (cli/tests/Vdk.Tests/CommandTestBase.cs).