Skip to content

fix: add command to create cloud provider kind#38

Merged
ewassef merged 2 commits intomainfrom
feat/add_cloud_provider_kind
Jun 18, 2025
Merged

fix: add command to create cloud provider kind#38
ewassef merged 2 commits intomainfrom
feat/add_cloud_provider_kind

Conversation

@edualogar
Copy link
Contributor

@edualogar edualogar commented Jun 15, 2025

This pull request introduces functionality for managing a new "Cloud Provider Kind" component in the Vega development environment. It includes commands to create and remove the component, updates to related services, and documentation changes. The most important changes are grouped below by theme.

New Commands for Cloud Provider Kind Management

  • Added CreateCloudProviderKindCommand to handle the creation of a "Cloud Provider Kind" container registry. (cli/src/Vdk/Commands/CreateCloudProviderKindCommand.cs)
  • Added RemoveCloudProviderKindCommand to handle the removal of the "Cloud Provider Kind" container registry. (cli/src/Vdk/Commands/RemoveCloudProviderKindCommand.cs)
  • Integrated the new commands into the CreateCommand and RemoveCommand classes. (cli/src/Vdk/Commands/CreateCommand.cs, cli/src/Vdk/Commands/RemoveCommand.cs) [1] [2]

Service Updates for Cloud Provider Kind

  • Updated DockerHubClient to include methods for creating and destroying the "Cloud Provider Kind" container. (cli/src/Vdk/Services/DockerHubClient.cs)
  • Modified IDockerEngine and LocalDockerClient to support connecting containers to a custom Docker network. (cli/src/Vdk/Services/IDockerEngine.cs, cli/src/Vdk/Services/LocalDockerClient.cs) [1] [2]

Registry Command Enhancements

  • Renamed methods in DockerHubClient and IHubClient to clarify their purpose (e.g., CreateCreateRegistry, DestroyDestroyRegistry). (cli/src/Vdk/Services/DockerHubClient.cs, cli/src/Vdk/Services/IHubClient.cs) [1] [2]
  • Updated CreateRegistryCommand and RemoveRegistryCommand to use the renamed methods. (cli/src/Vdk/Commands/CreateRegistryCommand.cs, cli/src/Vdk/Commands/RemoveRegistryCommand.cs) [1] [2]

Constants and Dependency Injection

  • Added constants for the "Cloud Provider Kind" container name and image in Containers.cs. (cli/src/Vdk/Constants/Containers.cs)
  • Registered the new commands in the dependency injection container. (cli/src/Vdk/ServiceProviderBuilder.cs)

Documentation

  • Added a new section to the command reference documentation for the vdk create cloud-provider-kind command. (docs/usage/command-reference.md)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a new command that creates a Cloud Provider KIND container, allowing users to test LoadBalancer services locally. Key changes include updates to the command-reference documentation, modifications to the Docker engine interfaces and implementations to include an optional network parameter, and new commands along with their registration for creating and removing the Cloud Provider KIND.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/usage/command-reference.md Added new command documentation for creating Cloud Provider KIND
cli/src/Vdk/Services/LocalDockerClient.cs Updated Run method to support an optional network parameter
cli/src/Vdk/Services/IHubClient.cs Added new interface methods for Cloud Provider KIND management
cli/src/Vdk/Services/IDockerEngine.cs Updated Run signature to include network parameter
DockerHubClient.cs and related command files Refactored and added new command implementations for Cloud Provider KIND
cli/src/Vdk/Constants/Containers.cs Added constants for Cloud Provider KIND
launchSettings.json Updated command line arguments for the new cloud provider kind command

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Eddie <eddie@wassef.com>
@ewassef ewassef merged commit 46299d1 into main Jun 18, 2025
2 checks passed
@ewassef ewassef deleted the feat/add_cloud_provider_kind branch June 18, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants