fix: add command to create cloud provider kind#38
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a new command that creates a Cloud Provider KIND container, allowing users to test LoadBalancer services locally. Key changes include updates to the command-reference documentation, modifications to the Docker engine interfaces and implementations to include an optional network parameter, and new commands along with their registration for creating and removing the Cloud Provider KIND.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/usage/command-reference.md | Added new command documentation for creating Cloud Provider KIND |
| cli/src/Vdk/Services/LocalDockerClient.cs | Updated Run method to support an optional network parameter |
| cli/src/Vdk/Services/IHubClient.cs | Added new interface methods for Cloud Provider KIND management |
| cli/src/Vdk/Services/IDockerEngine.cs | Updated Run signature to include network parameter |
| DockerHubClient.cs and related command files | Refactored and added new command implementations for Cloud Provider KIND |
| cli/src/Vdk/Constants/Containers.cs | Added constants for Cloud Provider KIND |
| launchSettings.json | Updated command line arguments for the new cloud provider kind command |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Eddie <eddie@wassef.com>
ewassef
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces functionality for managing a new "Cloud Provider Kind" component in the Vega development environment. It includes commands to create and remove the component, updates to related services, and documentation changes. The most important changes are grouped below by theme.
New Commands for Cloud Provider Kind Management
CreateCloudProviderKindCommandto handle the creation of a "Cloud Provider Kind" container registry. (cli/src/Vdk/Commands/CreateCloudProviderKindCommand.cs)RemoveCloudProviderKindCommandto handle the removal of the "Cloud Provider Kind" container registry. (cli/src/Vdk/Commands/RemoveCloudProviderKindCommand.cs)CreateCommandandRemoveCommandclasses. (cli/src/Vdk/Commands/CreateCommand.cs,cli/src/Vdk/Commands/RemoveCommand.cs) [1] [2]Service Updates for Cloud Provider Kind
DockerHubClientto include methods for creating and destroying the "Cloud Provider Kind" container. (cli/src/Vdk/Services/DockerHubClient.cs)IDockerEngineandLocalDockerClientto support connecting containers to a custom Docker network. (cli/src/Vdk/Services/IDockerEngine.cs,cli/src/Vdk/Services/LocalDockerClient.cs) [1] [2]Registry Command Enhancements
DockerHubClientandIHubClientto clarify their purpose (e.g.,Create→CreateRegistry,Destroy→DestroyRegistry). (cli/src/Vdk/Services/DockerHubClient.cs,cli/src/Vdk/Services/IHubClient.cs) [1] [2]CreateRegistryCommandandRemoveRegistryCommandto use the renamed methods. (cli/src/Vdk/Commands/CreateRegistryCommand.cs,cli/src/Vdk/Commands/RemoveRegistryCommand.cs) [1] [2]Constants and Dependency Injection
Containers.cs. (cli/src/Vdk/Constants/Containers.cs)cli/src/Vdk/ServiceProviderBuilder.cs)Documentation
vdk create cloud-provider-kindcommand. (docs/usage/command-reference.md)