Update to .NET 10 and adjust service references#44
Merged
Conversation
Bump target framework to net10.0 in Vdk and test projects, and update GitHub Actions workflow to use .NET 10.0.x. Also, update ReverseProxyClient to reference 'kgateway-system-kgateway' service instead of 'ingress-nginx-controller'.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the project from .NET 8.0 to .NET 10.0 and updates the reverse proxy service references from the ingress-nginx-controller to kgateway-system-kgateway. The changes reflect a migration to a new gateway system while modernizing the .NET framework version.
Changes:
- Updated target framework from net8.0 to net10.0 across project files
- Changed GitHub Actions workflow to use .NET 10.0.x for builds
- Replaced all ingress-nginx-controller service references with kgateway-system-kgateway in the reverse proxy client implementation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cli/src/Vdk/Vdk.csproj | Updated target framework to net10.0 and removed BOM character |
| cli/tests/Vdk.Tests/Vdk.Tests.csproj | Updated target framework to net10.0 |
| cli/src/Vdk/Services/ReverseProxyClient.cs | Updated service references from ingress-nginx-controller to kgateway-system-kgateway with corresponding namespace and log message updates |
| .github/workflows/build.yaml | Updated .NET version in CI/CD workflow to 10.0.x |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The System.CommandLine package was upgraded from the beta version to the stable 2.0.2 release, which introduced breaking API changes that required updates across all CLI command files. API changes addressed: - AddCommand() -> Subcommands.Add() for adding subcommands - AddOption() -> Options.Add() for adding options - SetHandler() extension -> SetAction() method for command handlers - Option constructor signature changed: description is now set via Description property instead of constructor parameter - InvokeAsync() on Command -> Parse(args).InvokeAsync() in Program.cs Files modified: - All command files under cli/src/Vdk/Commands/ - cli/src/Vdk/Program.cs Also normalizes line endings to LF per .gitattributes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request upgrades the project to .NET 10 and updates service references related to the reverse proxy client. The main changes include updating target frameworks and workflow configuration, as well as switching from the
ingress-nginx-controllerservice tokgateway-system-kgatewayin the codebase..NET Version Upgrade:
net10.0incli/src/Vdk/Vdk.csprojandcli/tests/Vdk.Tests/Vdk.Tests.csproj. [1] [2].github/workflows/build.yamlto use .NET version10.0.xfor builds.Reverse Proxy Service Reference Update:
PatchCoreDns(inReverseProxyClient.cs) fromingress-nginx-controllertokgateway-system-kgateway, including log messages and service lookups.