Conversation
Make FallbackDockerEngine tests safe to run on machines without Docker by checking connectivity in the test constructor and skipping tests when Docker is unavailable. Replaced [Fact] with [SkippableFact], added Skip.IfNot(_dockerAvailable, ...) to each test, and only pull the test image when Docker can be reached. Added a using Xunit and added the Xunit.SkippableFact package to the test project so tests can be conditionally skipped.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the FallbackDockerEngine tests resilient to environments where Docker is not available by implementing conditional test execution. Tests are now automatically skipped when Docker cannot be reached, preventing test failures on machines without Docker installed.
Changes:
- Added Xunit.SkippableFact package dependency to enable conditional test skipping
- Modified test constructor to check Docker availability and conditionally pull test images
- Converted all test methods from
[Fact]to[SkippableFact]with skip conditions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cli/tests/Vdk.Tests/Vdk.Tests.csproj | Added Xunit.SkippableFact package reference (v1.5.61) to enable conditional test skipping |
| cli/tests/Vdk.Tests/FallbackDockerEngineTests.cs | Added Docker availability check in constructor, converted tests to SkippableFact, and added skip conditions for when Docker is unavailable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make FallbackDockerEngine tests safe to run on machines without Docker by checking connectivity in the test constructor and skipping tests when Docker is unavailable. Replaced [Fact] with [SkippableFact], added Skip.IfNot(_dockerAvailable, ...) to each test, and only pull the test image when Docker can be reached. Added a using Xunit and added the Xunit.SkippableFact package to the test project so tests can be conditionally skipped.