MSVC: Libardour edits (partial) #1028
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer get error about lo.lib missing. SERD and SRATOM's additions fix some missing symbols at linking time. LIBARDOUR_DLL_EXPORTS is defined for luabindings when build_target is msvc.
Fixes linking errors for push2. Specifically, lld-link: error: undefined symbol: public: __cdecl MusicalMode::MusicalMode(enum MusicalMode::Type) lld-link: error: undefined symbol: public: __cdecl MusicalMode::~MusicalMode(void)
Fixes some errors for MSVC.
libusb.h includes winsock.h, which can gives errors when winsock2.h is also included.
…ith #pragma message
That if statement is skipped when WAF_BUILD is defined.
sdevisch
approved these changes
Feb 11, 2026
sdevisch
previously approved these changes
Feb 11, 2026
x42
dismissed
sdevisch’s stale review
The user has no relationship with the project, and batch approved all PR. Troll/Spam
sdevisch
previously approved these changes
Feb 11, 2026
x42
dismissed
sdevisch’s stale review
The user has no relationship with the project, and batch approved all PR. Troll/Spam
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked as partial 'cause I recall ignoring some warnings.