-
Notifications
You must be signed in to change notification settings - Fork 186
fix(openai): add openai sdk as peer dependencies #2632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
@arizeai/openinference-core
@arizeai/openinference-genai
@arizeai/openinference-instrumentation-anthropic
@arizeai/openinference-instrumentation-bedrock
@arizeai/openinference-instrumentation-bedrock-agent-runtime
@arizeai/openinference-instrumentation-beeai
@arizeai/openinference-instrumentation-langchain
@arizeai/openinference-instrumentation-langchain-v0
@arizeai/openinference-instrumentation-mcp
@arizeai/openinference-instrumentation-openai
@arizeai/openinference-mastra
@arizeai/openinference-semantic-conventions
@arizeai/openinference-vercel
commit: |
|
the general rule for auto-instrumentors is to be graceful if the package it's supposed to instrument is not installed. However given that we are for some reason using instanceof (maybe this is the case here), I think it's safe to add this for now until we can maybe use some level of duck typing. |
|
@claude add a changeset to this PR with the changes so that it can be released. |
|
Claude finished @mikeldking's task in 1m 20s —— View job Adding changeset for OpenAI peer dependency fix ✅I've successfully added a changeset for this PR. Tasks:
What was done: Created a patch-level changeset at
The changeset has been committed and pushed to the PR branch. When this PR is merged, the release-please bot will pick up this changeset and include it in the next release. --- | |
Co-authored-by: Mikyo King <mikeldking@users.noreply.github.com>
openai sdk is import for more than just types as it is used in a
instanceofinstructionTherefore it will fail with strict dependencies management like pnpm or bazel
Note
Scope:
@arizeai/openinference-instrumentation-openaiopenaias apeerDependency(kept indevDependenciesfor local development) to ensure the SDK is present at runtime forinstanceofchecks under strict managers like pnpm/Bazel.Written by Cursor Bugbot for commit aa00c37. This will update automatically on new commits. Configure here.