Draft
Conversation
theocean154
force-pushed
the
jb/rust
branch
24 times, most recently
from
a1b4fd6 to
236dbb3
Compare
|
it's a great work. right here waiting... |
theocean154
force-pushed
the
jb/rust
branch
3 times, most recently
from
7543941 to
faeda36
Compare
theocean154
force-pushed
the
jb/rust
branch
2 times, most recently
from
3c0b38b to
956ce64
Compare
theocean154
force-pushed
the
jb/rust
branch
11 times, most recently
from
8e7220d to
742a3a0
Compare
theocean154
force-pushed
the
jb/rust
branch
4 times, most recently
from
0766a59 to
c0e9216
Compare
|
Hey @theocean154 are you still working on this? I was wondering is it worth it to make a contribution to the C++ code or wait for this to merge since it seems it will replace all of the C++ code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for the blank PR content, I promise I will fill this in when its ready!