Skip to content

Massive changes #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Mamizu1028 wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Massive changes #86

Mamizu1028 wants to merge 13 commits into from

Conversation

@Mamizu1028
Copy link
Contributor

@Mamizu1028 Mamizu1028 commented Sep 22, 2025 •
edited
Loading

WIP (DO NOT MERGE)

  • Group System
    • API changes
    • Group Owner (Done)
    • Module Group, FeatureGroup, TopLevelGroup (Done)
  • Localization
    • API changes
    • Module Localization (Done)
    • Feature Localization (Done)
  • Definition Manager
    • Group Definition (Done)
  • Feature Settings
    • FSTooltip (WIP)
  • Feature
    • TopLevelGroup (Done)
  • Attributes
    • FeatureIncompatibility (WIP)
  • ArchivePatch
    • ArchiveAfter (Done)
    • ArchiveBefore (Done)
    • PriorityProvider (Done)
    • ReversePatch (Done?)
      • IsOriginal (Done)
      • IsSnapshot (Done)
  • New Features
    • FlickShotFix (Done)
    • GhostEnemyFix (Done)
    • ResourceInheritanceFix (Done)
    • WeaponAudioSyncFix (Done)
  • Feature Config
    • Reflection (WIP)
  • Translation (WIP)
  • Bug Fixes
    • SentryGunMarkerTweaks: SentryGun Ammo Percentage (Done)
    • CM_SettingsItem Update (WIP)
    • WIPs
  • WIPs

@Mamizu1028
Massive changes (WIP)
d295bcb 
Group system
Localization API
Definition Manager
FSTooltip
ArchivePatch After / Before / PriorityProvider
Feature GUID
@Mamizu1028
oops
a1d3f70
@Mamizu1028
Fix TheArchive.RichPresence group definition
d635dff
AuriRex
AuriRex reviewed Sep 24, 2025
View reviewed changes
Copy link
Owner

@AuriRex AuriRex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tooltip seems to be somewhat broken at the moment?
From my quick testing only RightSideOfElement worked properly, game issue?

Overall looks good tho 👍
Only a few missing xml doc comments that I can add later as well.

TheArchive.Core/Core/Settings/EnabledFeatures.cs
Copy link
Owner

@AuriRex AuriRex Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably migrate those from the 'old format'?
Else everyone's enabled features are going to be reset unless I missed something.

Copy link
Contributor Author

@Mamizu1028 Mamizu1028 Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Feature.Identifier is not unique, I actually recommend directly deleting all previous content.

@Mamizu1028
Copy link
Contributor Author

Mamizu1028 commented Sep 24, 2025 •
edited
Loading

Currently, Tooltip isn't applied to feature setting's submenu entry. I did a simple test before and it seems works, but I may have missed something. I will consider the compatibility issues between FSTooltip and FSDescription, and implement support for SubMenuSettings. Additionally, I discovered that all FeatureSettings contained within SubMenus cannot be persistently saved, as the IsDirty flag is not being set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AuriRex AuriRex AuriRex left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mamizu1028 @AuriRex