VideoPress: Only intercept video uploads when VideoPress is available by obenland · Pull Request #46894 · Automattic/jetpack

obenland · 2026-02-02T13:19:42Z

Fixes #44891
Fixes VIDP-42

Proposed changes:

Add a canUploadToVideoPress flag to the block editor state that determines whether VideoPress should handle video file uploads
On Dotcom sites (simple/atomic): always true (VideoPress shows appropriate errors/upsell if no plan)
On Jetpack sites: true only if VideoPress is active AND (user has plan OR free video available)
Update the VideoPress block's file transform to check this flag before intercepting video uploads
When the flag is false on Jetpack sites, the core/video block handles the upload to the local server instead

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Self-hosted Jetpack site with VideoPress module disabled:

Install Jetpack on a self-hosted WordPress site
Disable the VideoPress module in Jetpack → Settings → Performance
Create a new post
Drag a video file (MP4, MOV, etc.) into the editor
Expected: A core/video block is created and the video uploads to your local server
Before fix: A VideoPress block was created and the upload failed with "Enable Jetpack module to continue using VideoPress"

Self-hosted Jetpack site with VideoPress enabled but no plan (after using free video):

Enable VideoPress module
Upload one video (uses free video)
Drag another video file into the editor
Expected: A core/video block is created
Before fix: A VideoPress block was created and failed with quota error

Self-hosted Jetpack site with VideoPress enabled and plan:

Enable VideoPress module on a site with VideoPress plan
Drag a video file into the editor
Expected: A VideoPress block is created and upload succeeds

WordPress.com site:

On a WordPress.com site (any plan)
Drag a video file into the editor
Expected: A VideoPress block is created (shows appropriate error/upsell if no plan)

When a user drags a video file into the block editor, the VideoPress block was intercepting the upload even when VideoPress was disabled or the user couldn't upload to VideoPress. This resulted in confusing error messages instead of the expected core/video block behavior. This fix adds a `canUploadToVideoPress` flag that checks: - On Dotcom sites (simple/atomic): always true (VideoPress handles uploads) - On Jetpack sites: VideoPress must be active AND (user has plan OR free video available) When the flag is false on Jetpack sites, the core/video block handles the upload to the local server instead. Fixes #44891

github-actions · 2026-02-02T13:20:45Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

github-actions · 2026-02-02T13:20:46Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/videopress-block-forced-when-disabled branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/videopress-block-forced-when-disabled

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

- Add PHP tests for can_upload_to_videopress() Dotcom behavior - Add JS tests for canUploadToVideoPress check in transformFromFile.isMatch() - Fix plan check to use 'videopress-1tb-storage' feature

jp-launch-control · 2026-02-02T13:34:51Z

Code Coverage Summary

Coverage changed in 3 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/videopress/src/class-block-editor-extensions.php	4/66 (6.06%)	6.06%	5 💔
projects/packages/videopress/src/client/block-editor/blocks/video/transforms/index.tsx	20/57 (35.09%)	3.61%	0 💚
projects/packages/videopress/src/class-status.php	3/6 (50.00%)	50.00%	-3 💚

Full summary · PHP report · JS report

_{Coverage check overridden by

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
.}

Copilot

Pull request overview

This PR fixes a bug where the VideoPress block was forcibly inserted when dragging video files into the editor, even when VideoPress was disabled or unavailable on Jetpack sites. The fix introduces a new flag that determines whether VideoPress should intercept video uploads.

Changes:

Adds a canUploadToVideoPress flag to the block editor state that controls whether VideoPress handles video uploads
Implements logic to determine upload eligibility: always enabled on Dotcom sites, conditionally enabled on Jetpack sites based on VideoPress status and plan/quota availability
Updates the VideoPress block's file transform to check the flag before intercepting uploads, allowing core/video to handle uploads when VideoPress is unavailable

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`projects/packages/videopress/src/class-block-editor-extensions.php`	Adds the `can_upload_to_videopress()` method that determines upload eligibility based on site type, VideoPress status, plan support, and free video availability; exposes this as `canUploadToVideoPress` in the editor state
`projects/packages/videopress/src/client/block-editor/global.d.ts`	Adds TypeScript type definition for `canUploadToVideoPress` as `'' \| '1'` to match WordPress localization pattern
`projects/packages/videopress/src/client/block-editor/blocks/video/transforms/index.tsx`	Updates the file transform's `isMatch` method to check the `canUploadToVideoPress` flag before intercepting video uploads
`projects/packages/videopress/src/client/block-editor/blocks/video/transforms/test/index.tsx`	Adds comprehensive test coverage for the new flag checking logic including edge cases
`projects/packages/videopress/tests/php/Block_Editor_Extensions_Test.php`	Adds PHP unit tests for the `can_upload_to_videopress()` method covering Dotcom and Jetpack scenarios
`projects/packages/videopress/changelog/fix-videopress-block-forced-when-disabled`	Adds changelog entry documenting the fix

obenland added [Type] Bug When a feature is broken and / or not performing as intended [Feature] VideoPress A feature to help you upload and insert videos on your site. [Status] Needs Review This PR is ready for review. labels Feb 2, 2026

github-actions bot added [Package] VideoPress [Status] In Progress labels Feb 2, 2026

Add tests for canUploadToVideoPress and fix plan feature check

e58c350

- Add PHP tests for can_upload_to_videopress() Dotcom behavior - Add JS tests for canUploadToVideoPress check in transformFromFile.isMatch() - Fix plan check to use 'videopress-1tb-storage' feature

github-actions bot added the [Tests] Includes Tests label Feb 2, 2026

Only call setAccessible() on PHP < 8.1

b58247c

obenland added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Feb 2, 2026

obenland self-assigned this Feb 5, 2026

obenland marked this pull request as ready for review February 5, 2026 13:10

Copilot AI review requested due to automatic review settings February 5, 2026 13:10

Copilot started reviewing on behalf of obenland February 5, 2026 13:10 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VideoPress: Only intercept video uploads when VideoPress is available#46894

VideoPress: Only intercept video uploads when VideoPress is available#46894
obenland wants to merge 3 commits intotrunkfrom
fix/videopress-block-forced-when-disabled

obenland commented Feb 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 2, 2026

Uh oh!

github-actions bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

jp-launch-control bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

obenland commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Self-hosted Jetpack site with VideoPress module disabled:

Self-hosted Jetpack site with VideoPress enabled but no plan (after using free video):

Self-hosted Jetpack site with VideoPress enabled and plan:

WordPress.com site:

Uh oh!

github-actions bot commented Feb 2, 2026

Uh oh!

github-actions bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

obenland commented Feb 2, 2026 •

edited

Loading

github-actions bot commented Feb 2, 2026 •

edited

Loading

jp-launch-control bot commented Feb 2, 2026 •

edited

Loading