fix: increase max ad size to allow for label [NPPM-2395]

[laurelfulford]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR increases the max-width for the mobile sticky footer ad.

Right now it maxes out at 100px, and allows ads that are up to 100px; however, if you enable the Custom Ad Label, it's also included in the 100px space and pushes the ad down, cutting off a few pixels.

How to test the changes in this Pull Request:

1. Set up a test ad situation with a 320px x 100px ad creative, and assign it to the Sticky Mobile footer space (note: I had a heck of a time finding creative for this in our test account, so I faked testing it by editing the output, and testing with a taller ad creative - 300x250 - and seeing how much of it was visible. The fix is based off a real example on a publisher site, though).
2. Under Advertising > Settings, enable Custom Ad Label.
3. View on the front end and note the ad is touching the bottom of the sticky area - if you inspect the ad, you'll see it's overflowing the max-height.

4. Apply this PR and run npm run build.
5. Confirm that the ad is no longer touching the bottom:

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[dkoo]

I'm wondering if we need to be so restrictive about the max-height here? Like could we bump this up to something like 25vh? ccing @kmwilkerson in case you have some thoughts on this!

[laurelfulford]

@dkoo Good call! I followed up with Katie in Linear about that, and she said:

Oh yes this makes sense to me!!

... so I updated the height in 695d30f!

[laurelfulford]

Thanks @dkoo!

[github-actions]

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

[matticbot]

🎉 This PR is included in version 2.17.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 2.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀