Feature/template by karpikpl · Pull Request #40 · Avanade/CoreEx

karpikpl · 2022-09-28T16:18:15Z

Template for starting with CoreEx

Things to complete:

Readme file for the template
Readme file for Azure DevOps pipelines
Test for running the template with latest coreEX
Github actions workflows - most likely to be completed in another PR

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

chullybun

Can we please move $\src\Templates to $\tools\CoreEx.Template where the project name is CoreEx.Template etc. as this will eventually be published as a NuGet package and should follow our CoreEx.* naming convention. This should be the same as NTangle for consistency. This way src is reserved for genuine runtime deployed packages only.

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

chullybun · 2022-09-29T14:50:22Z

tools/CoreEx.Template/content/.azuredevops/pipeline-release copy.yml

+
+resources:
+  pipelines:
+  - pipeline: 'D365-Employee'  # Name of the pipeline resource


Should this be renamed as D365 is not relevant?

pipelines are work in progress - all those references will be removed

chullybun · 2022-09-29T14:51:27Z

tools/CoreEx.Template/content/.azuredevops/pipeline-release copy.yml

+  jobs:
+    - template: app-template.yml
+      parameters:
+        AzureSubscription: rg-priv-inte-dev-nte-na-01


is name configurable? nte-na does not seem correct?

that will be deleted

chullybun · 2022-09-29T14:53:00Z

tools/CoreEx.Template/content/.template.config/template.json

+  },
+  "sources": [
+    {
+    //   "modifiers": [


Should commented out content be removed?

I was thinking that template eventually will be more dynamic, but not this week. We can remove or keep it on todo

chullybun · 2022-09-29T14:54:40Z

tools/CoreEx.Template/content/Company.AppName.Api/Controllers/EmployeeController.cs

@@ -0,0 +1,89 @@
+namespace Company.AppName.Api.Controllers;
+
+[Route("api/employees")]


Route contains api does this need to be amended like my.hr?

I think function app adds /api but webapp doesn't

chullybun · 2022-09-29T18:35:22Z

tools/CoreEx.Template/content/.azuredevops/function-template.yml

+               #  deployToSlotOrASE: true
+              resourceGroupName: '$(ResourceGroupName)'
+              #slotName: '$(DeploymentSlot)'
+              package: '$(Pipeline.Workspace)/D365-Apps/D365-Apps_Package/Nte.Int.D365.Apps.FunctionApps.zip'


Another Nte reference

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

karpikpl · 2022-10-04T12:05:53Z

@chullybun can you check if template project has been added correctly?

chullybun · 2022-10-05T16:04:18Z

@karpikpl - i built the solution from this branch, deployed all packages locally, installed the dotnet template, then executed to create Foo.Bar, opened the .sln in Visual Studio 2022, and ran the included unit tests all successfully - nice work👍

Pulumi, infra, etc. testing I will get to probably next week - we have Adi looking into that.

Was there anything else you wanted me to validate?

karpikpl · 2022-10-07T14:57:09Z

I think that's it.
What wasn't working for me, was the running the template from nugget package due to OS permissions.

I've added a checklist on top on what is still pending.

karpikpl · 2022-10-14T14:44:18Z

If there's a risk of code going out of sync. maybe this can be merged and I can add other things as separate PRs?

Piotr added 20 commits September 22, 2022 14:28

work in progress

2d01c2e

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

init commit for templates

2b2a39a

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

docker for template

0894f76

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

settings and vs extensions

54fa7da

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

renaming database

8d4557f

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

renaming database

aadaa48

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

Fixes to DBName

9f5e050

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

excluding conditions for now

3e59452

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

build for template

c91d898

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

rename database

67a6955

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

dev container configured

774b2cf

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

adding features and function core tools

5adf94f

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

fixing connections tring in docker containers

ad2e720

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

HTTP files

5cc8b57

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

minor updates to infra stack

128301e

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

Merge remote-tracking branch 'origin' into feature/template

52e2e3f

developer setup in Infra

42ea8a9

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

remove infra from samples

0537c1d

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

fixing rename that happend by accident

a6f7632

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

fixing some comments

813cfcd

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

chullybun reviewed Sep 28, 2022

View reviewed changes

Piotr added 7 commits September 28, 2022 18:07

fixign tests

2819e08

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

fix my HR function test

eb6959d

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

fix CI

ee65338

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

test fix

5c1f2be

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

moving to tools folder

23d3715

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

update to CI

71f4f47

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

build template

d53ab46

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

chullybun reviewed Sep 29, 2022

View reviewed changes

Piotr added 13 commits September 29, 2022 14:37

removing extra files

aa81bbc

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

more generic names

237cdd6

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

stack rename

08fbade

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

infra deployments

a17e27d

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

replacing . with _ in deployment info

9510833

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

pipeline files

9d7af42

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

templates

97120d8

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

pipeline files

64bcf34

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

minor

4946903

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

health check

942f83a

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

Template project file

510ec22

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

preparing for template nuget

8c7a7d3

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

merge with main

a51c384

Signed-off-by: Piotr <karpik.pl+nospam@gmail.com>

Update nuget publish powershell.

1b266d9

		@@ -0,0 +1,89 @@
		namespace Company.AppName.Api.Controllers;

		[Route("api/employees")]

Conversation

karpikpl commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chullybun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karpikpl commented Oct 4, 2022

Uh oh!

chullybun commented Oct 5, 2022

Uh oh!

karpikpl commented Oct 7, 2022

Uh oh!

karpikpl commented Oct 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

karpikpl commented Sep 28, 2022 •

edited

Loading