feat: Retain pruned transactions until pruned block is finalised#20237
Open
PhilWindle wants to merge 2 commits intonextfrom
Open
feat: Retain pruned transactions until pruned block is finalised#20237PhilWindle wants to merge 2 commits intonextfrom
PhilWindle wants to merge 2 commits intonextfrom
Conversation
327f014 to
791b20f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements soft deletion for transactions from pruned blocks in TxPoolV2:
getTxByHashandhasTxs, with status'deleted'fromgetTxStatusKey Design Decisions
Track mined block, not prune point: When a tx is un-mined due to a reorg, we track the block it was mined in, not the block we pruned to. This ensures the tx is kept until that block is finalized on the new chain.
Handle re-mining: If a tx is mined at block 4, pruned, re-mined at block 5, then pruned again, we track block 5 (the higher value). The tx is only hard-deleted when block 5 is finalized.
Single source of truth:
DeletedPoolis responsible for ALL deletion decisions. It determines whether to soft-delete or hard-delete based on whether the tx is from a pruned block.Example Scenario
Test plan
🤖 Generated with Claude Code