feat(deploy): support workload identity updates from OSMO#40
Open
agreaves-ms wants to merge 1 commit intomainfrom
Open
feat(deploy): support workload identity updates from OSMO#40agreaves-ms wants to merge 1 commit intomainfrom
agreaves-ms wants to merge 1 commit intomainfrom
Conversation
- correct helm upgrade commands for service and web-ui - remove access_key_id from workflow config template 🔧 - Generated by Copilot
nguyena2
approved these changes
Jan 12, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates OSMO deployment configuration to support Azure workload identity authentication by removing legacy access key fields and correcting Helm chart OCI registry paths.
Changes:
- Corrected Helm chart OCI paths from
helm/osmo→helm/serviceandhelm/ui→helm/web-ui - Removed
access_key_idcredential fields from workload identity configuration template (not needed with workload identity) - Enabled data validation for Azure by clearing the
disable_data_validationarray
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| deploy/002-setup/config/workflow-config-workload-identity.template.json | Removed access_key_id from credential blocks and enabled Azure data validation to support workload identity authentication |
| deploy/002-setup/03-deploy-osmo-control-plane.sh | Corrected Helm chart OCI registry paths for OSMO service and web-ui components |
WilliamBerryiii
changed the title
WilliamBerryiii
changed the title
WilliamBerryiii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: support identity updates from OSMO
This PR updates Helm chart OCI registry paths for OSMO components and removes legacy credential fields from the workload identity configuration template.
Requires NVIDIA/OSMO#141 to be merged.
fix(deploy): Corrected Helm chart paths for OSMO service and web-ui components
oci://${acr_login_server}/helm/osmotooci://${acr_login_server}/helm/serviceoci://${acr_login_server}/helm/uitooci://${acr_login_server}/helm/web-uifix(config): Removed
access_key_idfrom workflow-config-workload-identity.template.jsonworkflow_data,workflow_log, andworkflow_appcredential blocksdisable_data_validationarray (previously contained"azure")chore(scripts): Changed workflow submission command from
osmotoosmo-devin submit-osmo-dataset-training.shchore(automation): Commented out Azure managed identity connection in Start-AzureResources.ps1
🔧 - Generated by Copilot