Conversation
mociarain
requested review from
bennerv,
cadenmarchese,
hawkowl,
hlipsig,
jharrington22,
kimorris27,
mrWinston,
rogbas,
sankur-codes,
tiguelu,
tsatam,
wanghaoran1988 and
yjst2012
as code owners
bizz001
reviewed
Jan 29, 2026
bizz001
reviewed
Jan 29, 2026
mociarain
force-pushed
the
mociarain/fix-nsg-flake
branch
from
f28a89f to
d4edb6e
Compare
tuxerrante
reviewed
Feb 2, 2026
Collaborator
|
LGTM |
aasserzo
reviewed
Feb 2, 2026
aasserzo
reviewed
Feb 2, 2026
Collaborator
|
LGTM |
Collaborator
Author
|
~~Note to reviewers: Tests are passing. It's just the know flake in the E2E cleanup: https://redhat-internal.slack.com/archives/C02ULBRS68M/p1770139948583639~~ |
alcasim
previously approved these changes
Feb 4, 2026
mociarain
dismissed
alcasim’s stale review
The merge-base changed after approval.
alcasim
previously approved these changes
Feb 5, 2026
mociarain
dismissed
alcasim’s stale review
The merge-base changed after approval.
tuxerrante
previously approved these changes
Feb 6, 2026
mociarain
dismissed
tuxerrante’s stale review
The merge-base changed after approval.
mociarain
dismissed
tuxerrante’s stale review
The merge-base changed after approval.
Use the gomega object to access the test operators Co-authored-by: Anton Asserzon <aasserzo@redhat.com>
mociarain
force-pushed
the
mociarain/fix-nsg-flake
branch
from
e21a944 to
ec54822
Compare
tuxerrante
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I observed several example where our E2E tests were failing due to this test. After a little pairing we came to the conclusion that a likely cause is the Update made to the cluster CR from the reconciler failing. We believe this fails because:
This PR moves to a Patch rather than an update which should avoid this problem.
On a wider note the only reason I can see that we add the annotation to the CR is so it can be picked up by the monitor and written as a metric... This seems brittle and I'd be in favour of just writing to the in-cluster prometheus from the ARO-Operator directly assuming https://github.com/openshift-online/architecture/pull/57 is accepted @alcasim in particular.