Remove d2s workers flag

[mociarain]

What this PR does / why we need it:

This PR removes the D2sWorker flag and allows the good work done here by @bizz001 to be realized.

We (@mrWinston & I) discovered this initially when seeing this error

Code="InvalidParameter" Message="The provided worker VM size 'Standard_D4s_v5' is invalid." Target="properties.workerProfiles['worker'].vmSize"

On investigation we saw that the size was valid but we were setting this RPFeatureFlag and that was failing validation. This meant that we couldn't use the other family of machines (and use our Azure capacity to it's fullest) with the current setup. Rather than add more code and clauses we decided to kill it and trust ourselves to be responsible and not spin up very large machines.

Test plan for issue:

• run make client
  • there was some stuff from running it but I think they're an outcome of a newer autorest version and unrelated to the core changes here.
• Current tests

Is there any documentation that needs to be updated for this PR?

Yes and they're done as part of this PR.

[mociarain]

Note for reviewers:

This is key change really. The rest is just tidying up signatures

[tuxerrante]

Maybe V3 should be dismissed since they're not published anymore by MSFT

https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/general-purpose/dsv4-series?tabs=sizebasic#sizes-in-series

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mociarain

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mociarain]

Note for reviews:

This comment is try but this will also enable these for our customers i.e 2 core worker machines.

This is fine according to Openshift docs](https://docs.redhat.com/en/documentation/openshift_container_platform/4.11/html/nodes/worker-nodes-for-single-node-openshift-clusters) and if we literally run our E2E tests on them then they must be fine for our clients.

IMO this seems like a nice win for everyone but maybe there is some reason we have hidden these machines from our customers??

[openshift-ci]

@mociarain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	52c901f	link	true	/test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.