[Modules] Added WEBSITE_CONTENTAZUREFILECONNECTIONSTRING to app settings#3885
Open
PoojithJain wants to merge 2 commits intoAzure:mainfrom
Open
[Modules] Added WEBSITE_CONTENTAZUREFILECONNECTIONSTRING to app settings#3885PoojithJain wants to merge 2 commits intoAzure:mainfrom
WEBSITE_CONTENTAZUREFILECONNECTIONSTRING to app settings#3885PoojithJain wants to merge 2 commits intoAzure:mainfrom
Conversation
…re binaries in blob
…re binaries in blob
WEBSITE_CONTENTAZUREFILECONNECTIONSTRING to app settings
Contributor
|
Mr. @PoojithJain, thank you for your contribution. A short ask: Would you have a test environment available to test the change? Even better - would you have a pipeline badge available that shows that the change works? If not, we have 2 options. Either
I'd probably also suggest to extend one of the test cases to make use of the storage parameter to test if the logic is sound :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
WEBSITE_CONTENTAZUREFILECONNECTIONSTRINGto app settings to store binaries in blobPipeline references
Type of Change
Please delete options that are not relevant.
Checklist