[k8s-extension] remove base url override in list extensions#9543
[k8s-extension] remove base url override in list extensions#9543logangeorge01 wants to merge 1 commit intoAzure:mainfrom
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @logangeorge01, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Release SuggestionsModule: k8s-extension
Notes
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Pull request overview
This PR removes a temporary base URL override that was added for testing the 2023-05-01-preview API version. The override is no longer needed as testing is complete, and the default production base URL (https://management.azure.com) is already correctly configured in the client constructor.
Changes:
- Removed temporary base URL override from the
extension_typesproperty method
private clouds have different arm endpoints so this base url override was breaking the
az k8s-extension extension-types list-by-locationcallThis checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.