Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates Cilium Go dependencies to newer versions, including a major Cilium version bump from v1.15.16 to v1.18.2. The update also removes deprecated kube-proxy configuration code that is no longer needed with the newer Cilium version.
- Updates Cilium from v1.15.16 to v1.18.2
- Updates various Go dependencies including golang.org/x packages and Azure SDK components
- Removes obsolete kube-proxy configuration code from the test framework
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates multiple Go dependencies to newer versions, including major Cilium upgrade |
| test/e2e/framework/azure/create-cilium-cluster.go | Removes deprecated kube-proxy configuration code |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| subnetkey := fmt.Sprintf("/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Network/virtualNetworks/%s/subnets/%s", c.SubscriptionID, c.ResourceGroupName, c.VnetName, c.SubnetName) | ||
| ciliumCluster.Properties.AgentPoolProfiles[0].VnetSubnetID = to.Ptr(subnetkey) | ||
|
|
||
| // Set the kubeproxy config |
There was a problem hiding this comment.
Why are we removing this in this PR ?
There was a problem hiding this comment.
after we updated armcontainerservice package to v4, the AKS KubeProxyConfig types/fields we are using no longer exist in armcontainerservice/v4; so we do not need KubeProxyConfig anymore...
There was a problem hiding this comment.
TCPFinTimeoutSeconds: to.Ptr(int32(120)), //nolint:gomnd // set by existing kube-proxy in hack/aks/kube-proxy.json
UDPTimeoutSeconds: to.Ptr(int32(300)), //nolint:gomnd // set by existing kube-proxy in hack/aks/kube-proxy.json
These values are being set by the hack/aks file and are they are already present in the new version ?
4 participants
Reason for Change:
This PR is to update cilium go dependencies
the AKS KubeProxyConfig types/fields we are using no longer exist in armcontainerservice/v4
Issue Fixed:
Requirements:
Notes: