Queued
Conversation
QxBytes
force-pushed
the
alew/acn-build-cil-log-collector
branch
4 times, most recently
from
4467bf2 to
c698c97
Compare
QxBytes
force-pushed
the
alew/acn-build-cil-log-collector
branch
from
c698c97 to
e24990f
Compare
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the cilium-log-collector artifact/image to the ACN official OneBranch build + signing pipeline so it’s versioned, packaged, and included in manifest generation alongside existing ACN components.
Changes:
- Wire
CILIUM_LOG_COLLECTOR_VERSIONthrough the pipeline and addcilium_log_collectorto the linux build matrices and manifest jobs. - Add OneBranch build script to produce the Fluent Bit plugin shared object (
out_azure_app_insights.so). - Add a pipeline Dockerfile to package the built
.sointo the Fluent Bit base image.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.pipelines/run-pipeline.yaml |
Adds cilium-log-collector to build + manifest stages (vars, refs, and manifest job). |
.pipelines/build/scripts/cilium-log-collector.sh |
New build script that compiles the cilium-log-collector Fluent Bit plugin .so. |
.pipelines/build/ob-prepare.steps.yaml |
Exposes ciliumLogCollectorVersion as a stage output variable via make. |
.pipelines/build/dockerfiles/cilium-log-collector.Dockerfile |
New Dockerfile that embeds the built .so into a Fluent Bit image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jpayne3506
previously approved these changes
Feb 6, 2026
santhoshmprabhu
previously approved these changes
Feb 6, 2026
signed binaries pipeline pushes to signed images path in our registry and the path is stored in an environment variable which we need to read and set as the url previously make cilium-log-collector-version for example wouldn't work because this pipeline pushes to a different url like acnpublic.azurecr.io/artifact/XXXXXX/buddy/cilium-log-collector:XXXXXX instead of acnpublic.azurecr.io/cilium-log-collector:XXXXXX
QxBytes
dismissed stale reviews from santhoshmprabhu and jpayne3506
via
b283359
santhoshmprabhu
approved these changes
Feb 9, 2026
jpayne3506
approved these changes
Feb 9, 2026
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Any commits made after this event will not be merged.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 9, 2026
* add cilium log collector to acn official build * address comments * fix where we pull cil log collector in acn signed pipeline signed binaries pipeline pushes to signed images path in our registry and the path is stored in an environment variable which we need to read and set as the url previously make cilium-log-collector-version for example wouldn't work because this pipeline pushes to a different url like acnpublic.azurecr.io/artifact/XXXXXX/buddy/cilium-log-collector:XXXXXX instead of acnpublic.azurecr.io/cilium-log-collector:XXXXXX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Add cilium log collector to acn official build/signing
Must be merged in after the main cilium log collector PR is merged in
Issue Fixed:
Requirements:
Notes:
Build is successful: https://dev.azure.com/msazure/One/_build/results?buildId=151952530&view=results