fix: remove linux-headers-generic as it was causing pkg not found errors#4217
Merged
fix: remove linux-headers-generic as it was causing pkg not found errors#4217
Conversation
it also doesn't seem to be necessary to build the binaries
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the linux-headers-generic package from two build scripts to resolve package not found errors that occurred after the package version bumped from -94 to -100. The PR demonstrates that BPF programs can be built successfully without this package, as the required kernel API headers are provided by linux-libc-dev.
Changes:
- Removed
linux-headers-genericfrom the apt-get install command in ipv6-hp-bpf.sh - Removed
linux-headers-genericfrom the apt-get install command in azure-iptables-monitor.sh
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .pipelines/build/scripts/ipv6-hp-bpf.sh | Removes linux-headers-generic from package dependencies for building IPv6 HP BPF programs |
| .pipelines/build/scripts/azure-iptables-monitor.sh | Removes linux-headers-generic from package dependencies for building Azure iptables monitor and block-iptables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camrynl
previously approved these changes
Feb 5, 2026
jpayne3506
previously approved these changes
Feb 5, 2026
Contributor
jpayne3506
left a comment
jpayne3506
left a comment
There was a problem hiding this comment.
This is not a major difference from the existing dockerfile build. I would expect this to impact the normal build as well, but it could also get patched out.
I am good with merging this and addressing other errors later.
pre-emptively remove linux-headers-generic from the ipv6 bpf prog dockerfile-- if we update the golang image it could start failing similarly since the golang image is based on ubuntu and the kernel may update removes linux-headers-generic from makefile since github action failing with same error
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
camrynl
approved these changes
Feb 6, 2026
jpayne3506
approved these changes
Feb 6, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
…ors (#4217) * fix: remove linux-headers-generic as it was causing pkg not found errors it also doesn't seem to be necessary to build the binaries * remove linux-headers-generic for acn pr and linter pre-emptively remove linux-headers-generic from the ipv6 bpf prog dockerfile-- if we update the golang image it could start failing similarly since the golang image is based on ubuntu and the kernel may update removes linux-headers-generic from makefile since github action failing with same error
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
linux-headers-generic recently bumped to -100 (previously -94) and now the package can't be found: https://dev.azure.com/msazure/One/_build/results?buildId=151906478&view=results . This removes those packages so the acn official/nonofficial build pipeline can be unblocked.
Azure iptables monitor and ipv6 build without it being installed:
azure iptables monitor: https://dev.azure.com/msazure/One/CCE%20Apps/_build/results?buildId=151929965&view=logs&j=d3a3756c-a55d-5820-67ec-8fc39ccdb431&t=94931ea8-4cd5-5621-2a4c-70bae38b9e5a&l=710
ipv6 bpf prog: https://dev.azure.com/msazure/One/CCE%20Apps/_build/results?buildId=151937724&view=logs&j=4e720d8a-b7a6-5390-d2aa-2d74f6cff204&t=b8b50c28-2f32-558b-9982-d0c444ebf20b&l=71
Issue Fixed:
See above
Requirements:
Notes:
ACN Unofficial: https://dev.azure.com/msazure/One/_build/results?buildId=151952637&view=results