Open
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Azure ResourceMover PowerShell module from AutoRest v3 to AutoRest v4. The migration involves updating model type namespaces, correcting parameter types, adding new parameter sets, and resolving breaking changes in the generated code.
Key Changes
- Updated model type namespaces from
Microsoft.Azure.PowerShell.Cmdlets.ResourceMover.Models.Api20230801toMicrosoft.Azure.PowerShell.Cmdlets.ResourceMover.Models - Replaced strongly-typed enum parameters with string parameters for flexibility
- Added new parameter sets and JSON-based input methods for various cmdlets
Reviewed Changes
Copilot reviewed 79 out of 79 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/StaticAnalysis/Exceptions/Az.ResourceMover/BreakingChangeIssues.csv | Documents breaking changes and exceptions for the v4 migration |
| src/ResourceMover/ResourceMover/help/*.md | Updates help documentation with corrected type names and parameter sets |
| src/ResourceMover/ResourceMover.Autorest/test/*.ps1 | Updates test files to use new parameter syntax |
| src/ResourceMover/ResourceMover.Autorest/examples/*.md | Updates example documentation with corrected type references |
| src/ResourceMover/ResourceMover.Autorest/custom/csharp/*.cs | Updates C# custom code with new model namespaces |
| ## EXAMPLES | ||
|
|
||
| ### Example 1: Validate the dependenciesss before remove of the Move Resources from Move Collection | ||
| ### Example 1: Validate the dependecies before remove of the Move Resources from Move Collection |
There was a problem hiding this comment.
There is a spelling error in 'dependecies'. It should be 'dependencies'.
Suggested change
| ### Example 1: Validate the dependecies before remove of the Move Resources from Move Collection | |
| ### Example 1: Validate the dependencies before remove of the Move Resources from Move Collection |
| ``` | ||
|
|
||
| Validate the dependencies before remove of the move resources from Move Collection. | ||
| Validate the dependecies before remove of the move resources from Move Collection. |
There was a problem hiding this comment.
There is a spelling error in 'dependecies'. It should be 'dependencies'.
Suggested change
| Validate the dependecies before remove of the move resources from Move Collection. | |
| Validate the dependencies before remove of the move resources from Move Collection. |
| ## EXAMPLES | ||
|
|
||
| ### Example 1: Validate the dependencies before remove of the Move Resources from Move Collection | ||
| ### Example 1: Validate the dependecies before remove of the Move Resources from Move Collection |
There was a problem hiding this comment.
There is a spelling error in 'dependecies'. It should be 'dependencies'.
Suggested change
| ### Example 1: Validate the dependecies before remove of the Move Resources from Move Collection | |
| ### Example 1: Validate the dependencies before remove of the Move Resources from Move Collection |
| ``` | ||
|
|
||
| Validate the dependencies before remove of the move resources from Move Collection. | ||
| Validate the dependecies before remove of the move resources from Move Collection. |
There was a problem hiding this comment.
There is a spelling error in 'dependecies'. It should be 'dependencies'.
Suggested change
| Validate the dependecies before remove of the move resources from Move Collection. | |
| Validate the dependencies before remove of the move resources from Move Collection. |
|
To the author of the pull request, |
isra-fel
added
the
autorest v4 migration
6 tasks
Member
|
/azp run |
Contributor
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
…ourceMover-to-autorest-v4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preannouncement PR:
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.