-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Migrate StorageAction module to tsp #29136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pan-Qi
wants to merge
4
commits into
main
Choose a base branch
from
Bernard-generate-storageaction-with-tsp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,7 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
| // Changes may cause incorrect behavior and will be lost if the code is regenerated. | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
|
Comment on lines
1
to
+4
|
||
| // Licensed under the Apache License, Version 2.0 (the ""License""); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
|
|
@@ -19,12 +22,8 @@ | |
| [assembly: System.Reflection.AssemblyCompanyAttribute("Microsoft")] | ||
| [assembly: System.Reflection.AssemblyCopyrightAttribute("Copyright © Microsoft")] | ||
| [assembly: System.Reflection.AssemblyProductAttribute("Microsoft Azure PowerShell")] | ||
| [assembly: System.Reflection.AssemblyTitleAttribute("Microsoft Azure PowerShell - StorageAction")] | ||
| [assembly: System.Reflection.AssemblyFileVersionAttribute("0.1.2")] | ||
| [assembly: System.Reflection.AssemblyVersionAttribute("0.1.2")] | ||
| [assembly: System.Reflection.AssemblyTitleAttribute("Microsoft Azure PowerShell - StorageActionsManagementClient")] | ||
| [assembly: System.Reflection.AssemblyFileVersionAttribute("1.0.0")] | ||
| [assembly: System.Reflection.AssemblyVersionAttribute("1.0.0")] | ||
| [assembly: System.Runtime.InteropServices.ComVisibleAttribute(false)] | ||
| [assembly: System.CLSCompliantAttribute(false)] | ||
|
|
||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/StorageAction/StorageAction.Autorest/docs/Az.StorageAction.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| "generate_Id": "3f2c49f4-d751-4192-8f46-6a62b3c249c4" | ||
| "generate_Id": "a74827d2-9c4e-448e-a965-56f6f587edee" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| directory: specification\storageactions\StorageAction.Management | ||
| commit: c6a6145cc42fb6ddc5743ecbcc958fb1bc96d015 | ||
| repo: Azure/azure-rest-api-specs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| options: | ||
| "@azure-tools/typespec-powershell": | ||
| service-dir: "src" | ||
| emitter-output-dir: "{output-dir}/{service-dir}/StorageAction/StorageAction.Autorest" | ||
| clear-output-folder: true | ||
| debug: true | ||
| azure: true | ||
| module-version: 0.1.0 | ||
| prefix: "Az" | ||
| subject-prefix: "StorageAction" | ||
| service-name: StorageAction | ||
| module-name: "{prefix}.{service-name}" | ||
| output-folder: "{output-dir}" | ||
| exclude-tableview-properties: | ||
| - Id | ||
| - Type | ||
|
|
||
| directive: | ||
| # Following are common directives which are normally required in all the RPs | ||
| # 1. Remove the unexpanded parameter set | ||
| # 2. For New-* cmdlets, ViaIdentity is not required | ||
| # Following two directives are v4 specific | ||
| - where: | ||
| variant: ^(Create|Update|Preview)(?!.*?(Expanded|JsonFilePath|JsonString)) | ||
| remove: true | ||
| - where: | ||
| variant: ^CreateViaIdentity.*$ | ||
| remove: true | ||
| # Remove commands | ||
| - where: | ||
| verb: Get | ||
| subject: Operation | ||
| remove: true | ||
| # Rename commands | ||
| - where: | ||
| subject: StorageTask | ||
| set: | ||
| subject: Task | ||
| - where: | ||
| verb: Invoke | ||
| subject: PreviewStorageTaskAction | ||
| set: | ||
| subject: TaskPreviewAction | ||
| - where: | ||
| subject: StorageTaskAssignment | ||
| set: | ||
| subject: TaskAssignment | ||
| - where: | ||
| subject: StorageTasksReport | ||
| set: | ||
| subject: TasksReport | ||
| - where: | ||
| parameter-name: SubscriptionId | ||
| set: | ||
| default: | ||
| name: SubscriptionId Default | ||
| description: Gets the SubscriptionId from the current context. | ||
| script: '(Get-AzContext).Subscription.Id' | ||
| # Add model cmdlets for creating parameter objects | ||
| - model-cmdlet: | ||
| - model-name: StorageTaskOperation | ||
| cmdlet-name: New-AzStorageActionTaskOperationObject | ||
| - model-name: StorageTaskPreviewBlobProperties | ||
| cmdlet-name: New-AzStorageActionTaskPreviewBlobPropertiesObject | ||
| - model-name: StorageTaskPreviewKeyValueProperties | ||
| cmdlet-name: New-AzStorageActionTaskPreviewKeyValuePropertiesObject |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,7 @@ | |
| - Additional information about change #1 | ||
| --> | ||
| ## Upcoming Release | ||
| * Migrated to typespec | ||
|
||
|
|
||
| ## Version 1.0.0 | ||
| * General availability for module Az.StorageAction | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
tools/StaticAnalysis/Exceptions/Az.StorageAction/BreakingChangeIssues.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "Module","ClassName","Target","Severity","ProblemId","Description","Remediation" | ||
| "Az.StorageAction","Get-AzStorageActionTask","Get-AzStorageActionTask","0","3000","The type of property 'IdentityUserAssignedIdentity' of type 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IStorageTask' has changed from 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IUserAssignedIdentities' to 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IManagedServiceIdentityUserAssignedIdentities'.","Change the type of property 'IdentityUserAssignedIdentity' back to 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IUserAssignedIdentities'." | ||
| "Az.StorageAction","New-AzStorageActionTask","New-AzStorageActionTask","0","3000","The type of property 'IdentityUserAssignedIdentity' of type 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IStorageTask' has changed from 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IUserAssignedIdentities' to 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IManagedServiceIdentityUserAssignedIdentities'.","Change the type of property 'IdentityUserAssignedIdentity' back to 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IUserAssignedIdentities'." | ||
| "Az.StorageAction","Update-AzStorageActionTask","Update-AzStorageActionTask","0","3000","The type of property 'IdentityUserAssignedIdentity' of type 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IStorageTask' has changed from 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IUserAssignedIdentities' to 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IManagedServiceIdentityUserAssignedIdentities'.","Change the type of property 'IdentityUserAssignedIdentity' back to 'Microsoft.Azure.PowerShell.Cmdlets.StorageAction.Models.IUserAssignedIdentities'." |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate copyright notice at lines 1 and 4. Remove the duplicate copyright header to avoid confusion.