Skip to content

Conversation

@efrainretana
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@efrainretana efrainretana requested review from a team February 6, 2026 19:32
Copilot AI review requested due to automatic review settings February 6, 2026 19:32
@github-actions github-actions bot added the Mgmt This issue is related to a management package. label Feb 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Azure.ResourceManager.Search management SDK to target the 2026-03-01-preview ARM API version and adds newly introduced operations/models (notably Tenant-level Offerings listing, additional identity/encryption related models, and new/updated SKU-related types).

Changes:

  • Switch generator configuration and generated clients to 2026-03-01-preview.
  • Add Offerings (tenant-level) operation surface, including REST operations, extensions, and sample.
  • Add/update generated models for new API surface (offerings types, identity polymorphism, encryption key, domain label scope, new SKU values).

Reviewed changes

Copilot reviewed 1 out of 74 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/search/Azure.ResourceManager.Search/tests/Generated/Samples/Sample_TenantResourceExtensions.cs Adds sample for tenant-level Offerings listing.
sdk/search/Azure.ResourceManager.Search/tests/Generated/Samples/Sample_SubscriptionResourceExtensions.cs Updates sample provenance comments to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/tests/Generated/Samples/Sample_SharedSearchServicePrivateLinkResourceCollection.cs Updates sample provenance comments to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/tests/Generated/Samples/Sample_SharedSearchServicePrivateLinkResource.cs Updates sample provenance comments to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/tests/Generated/Samples/Sample_SearchServiceNetworkSecurityPerimeterConfigurationResource.cs Updates sample provenance comments to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/tests/Generated/Samples/Sample_SearchServiceNetworkSecurityPerimeterConfigurationCollection.cs Updates sample provenance comments to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/tests/Generated/Samples/Sample_SearchPrivateEndpointConnectionResource.cs Updates sample provenance comments to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/tests/Generated/Samples/Sample_SearchPrivateEndpointConnectionCollection.cs Updates sample provenance comments to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/src/autorest.md Points generation to newer swagger readme/tag for 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/src/Generated/SharedSearchServicePrivateLinkResourceCollection.cs Updates default API version docs to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/src/Generated/SharedSearchServicePrivateLinkResource.cs Updates default API version docs to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/src/Generated/SearchServiceNetworkSecurityPerimeterConfigurationResource.cs Updates default API version docs to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/src/Generated/SearchServiceNetworkSecurityPerimeterConfigurationCollection.cs Updates default API version docs to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/src/Generated/SearchServiceData.cs Adds/updates properties for new API (e.g., domain label scope) and doc updates.
sdk/search/Azure.ResourceManager.Search/src/Generated/SearchServiceData.Serialization.cs Adds serialization/deserialization for new properties (domain label scope).
sdk/search/Azure.ResourceManager.Search/src/Generated/SearchServiceCollection.cs Updates default API version docs to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/src/Generated/SearchPrivateEndpointConnectionResource.cs Updates default API version docs to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/src/Generated/SearchPrivateEndpointConnectionCollection.cs Updates default API version docs to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/src/Generated/RestOperations/UsagesRestOperations.cs Bumps default api-version and updates parameter docs.
sdk/search/Azure.ResourceManager.Search/src/Generated/RestOperations/SharedPrivateLinkResourcesRestOperations.cs Bumps default api-version and updates parameter docs.
sdk/search/Azure.ResourceManager.Search/src/Generated/RestOperations/ServicesRestOperations.cs Bumps default api-version and updates parameter docs.
sdk/search/Azure.ResourceManager.Search/src/Generated/RestOperations/SearchManagementRestOperations.cs Bumps default api-version and updates parameter docs.
sdk/search/Azure.ResourceManager.Search/src/Generated/RestOperations/QueryKeysRestOperations.cs Bumps default api-version and updates parameter docs.
sdk/search/Azure.ResourceManager.Search/src/Generated/RestOperations/PrivateLinkResourcesRestOperations.cs Bumps default api-version and updates parameter docs.
sdk/search/Azure.ResourceManager.Search/src/Generated/RestOperations/PrivateEndpointConnectionsRestOperations.cs Bumps default api-version and updates parameter docs.
sdk/search/Azure.ResourceManager.Search/src/Generated/RestOperations/OfferingsRestOperations.cs Adds new REST client for tenant-level Offerings endpoint.
sdk/search/Azure.ResourceManager.Search/src/Generated/RestOperations/NetworkSecurityPerimeterConfigurationsRestOperations.cs Bumps default api-version and updates parameter docs.
sdk/search/Azure.ResourceManager.Search/src/Generated/RestOperations/AdminKeysRestOperations.cs Bumps default api-version and updates parameter docs.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/UnknownDataIdentity.cs Adds “unknown discriminator” type for DataIdentity polymorphism.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/UnknownDataIdentity.Serialization.cs Adds serialization hooks for UnknownDataIdentity proxy.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SkuOfferingLimits.cs Adds model for per-SKU per-region limits.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SkuOfferingLimits.Serialization.cs Adds serialization for SkuOfferingLimits.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SkuOffering.cs Adds model for SKU offering entry (SKU + limits).
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SkuOffering.Serialization.cs Adds serialization for SkuOffering.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SearchSku.cs Updates SKU doc text to include new serverless tier.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SearchServiceSkuName.cs Adds Serverless SKU value.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SearchServicePublicInternetAccess.cs Updates wire values/casing for public network access.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SearchServicePatch.cs Adds domain label scope and updates doc text for enum casing.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SearchServicePatch.Serialization.cs Adds serialization/deserialization for domain label scope.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SearchServiceHostingMode.cs Updates doc text for enum casing.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SearchServiceHostingMode.Serialization.cs Updates wire string mapping for hosting mode.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SearchServiceComputeType.cs Updates wire values/casing for compute type.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SearchResourceEncryptionKey.cs Adds model for service-level encryption key configuration.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SearchResourceEncryptionKey.Serialization.cs Adds serialization for SearchResourceEncryptionKey.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SearchEncryptionWithCmk.cs Adds ServiceLevelEncryptionKey property.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SearchEncryptionWithCmk.Serialization.cs Adds serialization/deserialization for ServiceLevelEncryptionKey.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/SearchBypass.cs Adds AzurePortal bypass value.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/OfferingsListResult.cs Adds model for Offerings list response wrapper.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/OfferingsListResult.Serialization.cs Adds serialization for OfferingsListResult.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/OfferingsByRegion.cs Adds model for region-scoped offerings entry.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/OfferingsByRegion.Serialization.cs Adds serialization for OfferingsByRegion.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/FeatureOffering.cs Adds model for feature offering entry.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/FeatureOffering.Serialization.cs Adds serialization for FeatureOffering.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/DomainNameLabelScope.cs Adds extensible enum for endpoint domain label reuse scope.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/DataUserAssignedIdentity.cs Adds derived type for DataIdentity polymorphism.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/DataUserAssignedIdentity.Serialization.cs Adds serialization for DataUserAssignedIdentity.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/DataNoneIdentity.cs Adds derived type for “clear identity” scenario.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/DataNoneIdentity.Serialization.cs Adds serialization for DataNoneIdentity.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/DataIdentity.cs Adds base class for identity polymorphism.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/DataIdentity.Serialization.cs Adds polymorphic discriminator-based deserialization + proxy.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/AzureResourceManagerSearchContext.cs Registers new models for source-generated reader/writer context.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/AzureActiveDirectoryApplicationCredentials.cs Adds model for AAD credentials used for Key Vault access.
sdk/search/Azure.ResourceManager.Search/src/Generated/Models/AzureActiveDirectoryApplicationCredentials.Serialization.cs Adds serialization for AzureActiveDirectoryApplicationCredentials.
sdk/search/Azure.ResourceManager.Search/src/Generated/Extensions/SearchExtensions.cs Adds tenant-level Offerings extension methods + api-version doc bumps.
sdk/search/Azure.ResourceManager.Search/src/Generated/Extensions/MockableSearchTenantResource.cs Adds mockable tenant resource wrapper for Offerings operation.
sdk/search/Azure.ResourceManager.Search/src/Generated/Extensions/MockableSearchSubscriptionResource.cs Updates default API version docs to 2026-03-01-preview.
sdk/search/Azure.ResourceManager.Search/src/Generated/Extensions/MockableSearchResourceGroupResource.cs Updates default API version docs to 2026-03-01-preview.


base.JsonModelWriteCore(writer, options);
writer.WritePropertyName("userAssignedIdentity"u8);
writer.WriteStringValue(UserAssignedIdentity);
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utf8JsonWriter.WriteStringValue doesn't accept ResourceIdentifier, so this line will not compile. Convert UserAssignedIdentity to a string (e.g., UserAssignedIdentity.ToString()), matching how other ARM models serialize resource IDs.

Suggested change
writer.WriteStringValue(UserAssignedIdentity);
writer.WriteStringValue(UserAssignedIdentity.ToString());

Copilot uses AI. Check for mistakes.
Comment on lines +32 to +35
TenantResource tenantResource = client.GetTenants().GetAllAsync().GetAsyncEnumerator().Current;

// invoke the operation and iterate over the result
await foreach (OfferingsByRegion item in tenantResource.GetOfferingsAsync())
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetAsyncEnumerator().Current is accessed before the enumerator is advanced, so tenantResource will be null/default and the following call will throw at runtime. Please obtain a tenant by iterating (e.g., await foreach over client.GetTenants().GetAllAsync() and take the first item).

Copilot uses AI. Check for mistakes.
/// </list>
/// <item>
/// <term>Mocking</term>
/// <description>To mock this method, please mock <see cref="MockableSearchTenantResource.GetOfferings(CancellationToken)"/> instead.</description>
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XML doc for GetOfferingsAsync says to mock MockableSearchTenantResource.GetOfferings(...), but the async extension actually delegates to GetOfferingsAsync(...). Update the <see cref=...> reference so it points to the async mockable method.

Suggested change
/// <description>To mock this method, please mock <see cref="MockableSearchTenantResource.GetOfferings(CancellationToken)"/> instead.</description>
/// <description>To mock this method, please mock <see cref="MockableSearchTenantResource.GetOfferingsAsync(CancellationToken)"/> instead.</description>

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.Search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant