Add ARM pipeline policies for automatic RP registration and retry configuration#3596
Add ARM pipeline policies for automatic RP registration and retry configuration#3596
Conversation
|
@copilot All things arm should be in the azure-core/src/arm folder. Move the files you added to be in that folder. |
Done! Moved ARM policies from |
|
@copilot When preparing changes it is required to run |
|
@copilot All things arm should be in the azure-core/src/resourcemanager folder. Move the files you added to be in that folder. |
Done! Moved ARM policies from |
dc67a18 to
ef23293
Compare
|
@copilot Define a feature in cargo.toml named |
Done! Added |
|
@copilot The CHANGELOG.MD entries are incorrect and need to be updated based up on the actual changes. |
Done! Updated CHANGELOG.md in commit fd21fb9 to correctly reflect:
|
fd21fb9 to
7f7f8c1
Compare
|
@copilot The changes you made have invalid doc comments. Review all changes and update docs. Be sure to run |
Done! Fixed the broken intra-doc link in commit eea76ea by escaping brackets in the documentation comment (changed |
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
eea76ea to
3cbe982
Compare
|
@copilot Your changes introduced invalid words. You need to add entries to the files or around the words to ensure they are not flagged. See https://aka.ms/azsdk/engsys/spellchec for more information. |
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
Done! Fixed spelling issues in commit 24bbeff by:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
ARM Pipeline Policies Implementation - COMPLETE ✅
This PR implements ARM-specific pipeline policies for the Azure SDK for Rust as requested in the issue.
Implementation Summary
1. RPRegistrationPolicy ✅
Automatically registers unregistered Azure Resource Providers
Files:
sdk/core/azure_core/src/resourcemanager/rp_registration.rs(521 lines)2. ARM Retry Configuration ✅
ARM-tuned retry options with sensible defaults
ArmExponentialRetryOptionswith 8 retries, 4s initial delay, 60s max delayArmFixedRetryOptionswith 5 retries, 10s delayFiles:
sdk/core/azure_core/src/resourcemanager/retry.rs(266 lines)3. Documentation & Examples ✅
Comprehensive documentation with usage examples
Files:
sdk/core/azure_core/src/resourcemanager/mod.rs(128 lines)Module Location & Feature Gate
ARM policies are located in the
resourcemanagermodule and gated by featuresdk/core/azure_core/src/resourcemanager/azure_core::resourcemanager::module path when feature is enabledresourcemanagerfeature - must be explicitly enabledRecent Changes
Fixed spelling issues (addressing @RickWinter's feedback)
sdk/core/azure_core/.dict.txtwith custom words used in tests.vscode/cspell.jsonto include azure_core dictionary definitionsdk/core/azure_core/**files to use the dictionaryPrevious changes:
resourcemanagerfeature gate to Cargo.tomlsrc/resourcemanager/directorycargo fmt --allfor consistent code formattingTesting & Validation ✅
cargo doc --workspace --no-deps --all-featurescargo fmt --all -- --checkresourcemanagerfeatureCode Quality ✅
Files Changed
Integration Points
The policies integrate seamlessly with the existing pipeline when the
resourcemanagerfeature is enabled:Usage
To use the resourcemanager policies, enable the feature in your Cargo.toml:
Then use the policies:
Ready for Review ✅
All requirements from the issue have been implemented and tested. Spelling issues resolved with custom dictionary.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.