Upgrade Faraday to Version 2.0

[honeyankit]

🖼️ Context

Upgrading the Faraday gem from version 1.0.0 to 2.0.

fix #227

✅ Approach

• In the process of upgrading the faraday gem to version 2.0 from 1.0, I need to remove the faraday_middleware as it has been deprecated based on its docs and need to use the middleware faraday-follow_redirects. Details are present in the awesome-faraday docs.
• Based on the Faraday upgrade docs, all the adapters, except for the net_http, have already been moved out and released as separate gems. So I had to add adapter faraday-net_http_persistent (gem) as part of this upgrade.

[honeyankit]

I was able to do the testing with command rake test:unit --trace. First I ran with the test with the original code (ie. faraday 1.0 and faraday-middleware) then I updated the Faraday to 2.0 and removed faraday-middleware and added necessary adapters and middlewares.

Note: For the unit test, I was getting same 135 failures before as well after the upgrades during the running of the unit test (rake test:unit --trace)

[mhais22]

are there plans to merge this?

[grncdr]

These are very similar changes to what was done on my own fork. However, I don't think anybody is really actively maintaining this Gem any more.

[serprex]

citusdata is a Microsoft organization maintaining a fork https://github.com/citusdata/azure-storage-ruby/tree/faraday2 unfortunately when I tried looking into whether the citus team could take over maintaining this gem the email thread went nowhere

[honeyankit]

We had to create our own forks in the GitHub org and take the changes as Microsoft is not maintaining this repo anymore. I would be happy if they accept this PR, at-least for the short term it will unblock many folks.

Alternatively, folks can use the below below forked repo.
https://github.com/honeyankit/azure-storage-ruby

[allisonphillips]

Thanks for this!

To fix the broken tests:

• test/support/stubs.rb needs require "minitest/unit"
• Upgraded the mocha dev dependency to "~> 2.0"

There are some deprecation warnings about the use of must_equal in the tests, so you'll likely want to update expectations like subject.uri.must_equal 'http://dummy.uri' to _(subject.uri).must_equal 'http://dummy.uri'