Ensure nodeName uses landing_zones with underscore#1172
Ensure nodeName uses landing_zones with underscore#1172arrerezai wants to merge 1 commit intoAzure:mainfrom
Conversation
|
@arrerezai - is this still required? Sorry for the long time of approving this - but now looking at it, this doesn't seem critical - and unless there is a justified reason I know if we approve this, then people running the sync command will see every file within ALZ and/or AMBA has updates and it might be a small nuisance for people. |
|
@apybar , too long has passed since I created this PR now but the consensus was (and probably is) that the sync always got me duplicated things as the correct nodeName should be landing_zones, while in fact, the sync created duplicates but for nodeName landingzones instead (i.e. it couldn't figure out that landing_zones already existed from before and hence created landingzones because of the diff). While I have added this commit to my own stuff (and it works as intended), you may want to reject this PR but have in mind, others might experience the same issue upon sync... |
|
Moreover, just tried to sync using epac v11.2.2 (without my own fix as proposed through this PR). This is the command I am running: |
We had the same issue and had to rename all the nodes to get the sync to work with no diff 😬 |
|
@johanandrelundar Appreciate that you also provide feedback and show that the problem is not local to me but that everyone is getting this diff as a result of a minor error in the node name. |
|
If you accept the change, does it modify the file again on the next sync? The node name property has no effect on the assignment.
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Arash Rezai ***@***.***>
Sent: Wednesday, February 25, 2026 7:40:31 PM
To: Azure/enterprise-azure-policy-as-code ***@***.***>
Cc: Anthony Watherston ***@***.***>; Review requested ***@***.***>
Subject: Re: [Azure/enterprise-azure-policy-as-code] Ensure nodeName uses landing_zones with underscore (PR #1172)
[https://avatars.githubusercontent.com/u/157028889?s=20&v=4]arrerezai left a comment (Azure/enterprise-azure-policy-as-code#1172)<#1172 (comment)>
@johanandrelundar<https://github.com/johanandrelundar> Appreciate that you also provide feedback and show that the problem is not local to me but that everyone is getting this diff as a result of a minor error in the node name.
@apybar<https://github.com/apybar> Although not super important, might be nice to have it fixed now that you know that folks out there are experiencing the same incorrect behavior, no? Doesn't need to be the way I do it, just any working way, but speeds up things tremendously having no diffs due to errors and results in people wanting to run the sync more often than not.
—
Reply to this email directly, view it on GitHub<#1172 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACWCJVW6Y24VHHSTJRE57WD4NVNX7AVCNFSM6AAAAACOZLFVBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNJXGY4DANRRHA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
@anwather Clearly, I can fix it by accepting the change, but that indicates the nodeName changed in one of the former releases? How and why? Of course the nodeName property can hold any value without any negative impact, but as goes for the sync and comparing deviations from former versions, it is quite disturbing if the nodeName is meant to be changed randomly. |
|
@anwather New discovery! After accepting the change, running the same command again and again would not modify the files again, however, running the sync command, not specifying the -EnableOverrides flag places the underscore back according to: 
|
|
Ok - I think this is something we can fix, without looking at the code I know there was something I had to change about the landing zone naming to get the overrides to work. |
4 participants
Ensure nodeName uses landing_zones with underscore instead of landingzones.