Skip to content

Added skills - code researcher, kusto analyst, incident investigator, Fixes AB#3505913#389

Open
somalaya wants to merge 2 commits intomasterfrom
somalaya/AddSkills
Open

Added skills - code researcher, kusto analyst, incident investigator, Fixes AB#3505913#389
somalaya wants to merge 2 commits intomasterfrom
somalaya/AddSkills

Conversation

@somalaya
Copy link
Contributor

@somalaya somalaya commented Feb 3, 2026

Added skills similar to this PR created by Cesar in AuthApp https://msazure.visualstudio.com/DefaultCollection/One/_git/AD-MFA-phonefactor-phoneApp-android/pullrequest/14534965?_a=files

Also moved a lot of instructions from copilot-instructions.md file to skills to make the file leaner.

Fixes AB#3505913

@somalaya somalaya requested a review from a team as a code owner February 3, 2026 23:35
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

|----------|-------|
| **Cluster URL** | `https://idsharedeus2.kusto.windows.net/` |
| **Production Database** | `ad-accounts-android-otel` |
| **Sandbox Database** | `android-broker-otel-sandbox` |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to expose this information publicly? These skills are exposed publicly and while these database names are controlled by RBAC, the less information we provide about the specific internal data the better unless absolutely necessary

You could make the same argument about the specific queries that we run that is only useful to our team internally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick search and found this.

The access flow requires:

  • Know the cluster URL ✓ (in this doc)
  • Know the database name ✓ (in this doc)
  • Know the security group name ❌ (NOT in this doc)
  • Get group membership approved ❌ (requires manager/owner approval)

Without the group name, an attacker would have to:

  • Guess the group name (difficult with GUID-based or internal naming)
  • Ask someone who knows (social engineering)
  • Have existing Azure AD permissions to enumerate groups (already compromised)

Based on this, I think it is safe to put the Cluster URI and DB Name here.

@somalaya somalaya changed the title Added skills - code researcher, kusto analyst, incident investigator Added skills - code researcher, kusto analyst, incident investigator, Fixes AB#3505913 Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

✅ Work item link check complete. Description contains link AB#3505913 to an Azure Boards work item.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

❌ Work item link check failed. Description contains AB#3505913 but the Bot could not link it to an Azure Boards work item.

Click here to learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants