Add test hook to PopKeyAttestor for MSI v2 attestation tests#5694
Merged
Add test hook to PopKeyAttestor for MSI v2 attestation tests#5694
Conversation
- Add s_testAttestationOverride static field in PopKeyAttestor.cs - Update AttestCredentialGuardAsync to check test override before loading native DLL - Update TestAttestationProviders.cs to add CreateFakeAttestationResultProvider - Update ImdsV2Tests to inject and cleanup test override Co-authored-by: gladjohn <90415114+gladjohn@users.noreply.github.com>
- Add documentation about InternalsVisibleTo and thread-safety concerns - Remove trailing whitespace in test cleanup method Co-authored-by: gladjohn <90415114+gladjohn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add test hook in PopKeyAttestor for mocking attestation
Add test hook to PopKeyAttestor for MSI v2 attestation tests
Jan 31, 2026
bgavrilMS
reviewed
Feb 2, 2026
tests/Microsoft.Identity.Test.Unit/ManagedIdentityTests/TestAttestationProviders.cs
Show resolved
Hide resolved
bgavrilMS
requested changes
Feb 2, 2026
Member
bgavrilMS
left a comment
There was a problem hiding this comment.
Too much test code in the product code for 1 trivial test.
bgavrilMS
approved these changes
Feb 3, 2026
bgavrilMS
reviewed
Feb 3, 2026
src/client/Microsoft.Identity.Client.KeyAttestation/PopKeyAttestor.cs
Outdated
Show resolved
Hide resolved
Address feedback from @bgavrilMS to improve naming consistency Co-authored-by: gladjohn <90415114+gladjohn@users.noreply.github.com>
gladjohn
approved these changes
Feb 5, 2026
trwalke
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this request
Unit tests calling
.WithAttestationSupport()fail becausePopKeyAttestor.AttestCredentialGuardAsync()loadsAttestationClientLib.dll, which throwsTaskCanceledExceptionin test environments and makes network calls that bypassMockHttpManager.Solution: Test hook pattern to inject mock attestation provider.
Core changes:
s_testAttestationProviderstatic field checked before native DLL loadingCreateFakeProvider()withCreateFakeAttestationResultProvider()returningAttestationResultTestInitialize, reset inTestCleanupAll 27+ existing test calls to
.WithAttestationSupport()now bypass native DLL without modification.Testing
Test infrastructure updated. Existing unit tests in
ImdsV2Testsnow use the mock provider automatically. No new tests added—fix enables existing tests to run.Performance impact
None. Production code path unchanged. Test-only hook accessed via
InternalsVisibleTo.Documentation
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.