-
Notifications
You must be signed in to change notification settings - Fork 157
[patch][engg]: Add PR review instructions #2853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds a new “Basic Code Review Guidelines” section to .github/copilot-instructions.md to standardize how reviews are performed for this repo.
Changes:
- Introduces a concise checklist for review behavior (scope, aggregation of feedback, comment structure).
- Adds guidance around avoiding formatting nits, adhering to repo conventions, and guarding against leaks/crashes.
- Emphasizes expectations around providing actionable recommendations and safe replacements.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
swasti29
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why other files are missing for this? will it pick from Common Core?
@swasti29, the other files were already merged in a previous PR, MSAL was only missing thes updates. |
Proposed changes
This pull request updates the
.github/copilot-instructions.mdfile to add a set of basic code review guidelines. These guidelines are intended to enforce consistency and clarity during code reviews.Code review process improvements:
Type of change
Risk
Additional information