Skip to content

Conversation

@kaisong1990
Copy link
Contributor

@kaisong1990 kaisong1990 commented Feb 11, 2026

PR Title Format

Required Format: [Keyword1] [Keyword2]: Description

  • Keyword1: major, minor, or patch (case-insensitive)
  • Keyword2: feature, bugfix, engg, or tests (case-insensitive)

Examples:

  • [MAJOR] [Feature]: new API
  • [minor] [bugfix]: fix crash
  • [PATCH] [tests]: add coverage

Proposed changes

Describe what this PR is trying to do.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

AB#3407672

@kaisong1990 kaisong1990 requested a review from a team as a code owner February 11, 2026 06:16
@@ -1 +1 @@
Subproject commit f2466fa960ccfd8e500cab6f1d12b4127c6e63e1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

@kaisong1990 kaisong1990 changed the title [minor][feature] add execution flow support for acquireTokenInteractive and acquireTokenSilent into MSAL sample app and update submodule [minor][feature] MSAL sample app: Add execution flow support for acquireTokenInteractive and acquireTokenSilent and update submodule Feb 11, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds execution-flow logging support to the MSAL sample app’s interactive and silent token acquisition flows (macOS + iOS) and updates the IdentityCore submodule.

Changes:

  • Registered per-request correlation IDs and used MSIDExecutionFlowLogger to retrieve/flush execution flows after token operations.
  • Extended result/error rendering to include executionFlow output.
  • Updated MSAL/IdentityCore submodule reference.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
MSAL/test/app/mac/MSALAcquireTokenViewController.m Adds correlation IDs + execution-flow logging around interactive/silent flows and surfaces execution-flow in UI output.
MSAL/test/app/ios/MSALTestAppAcquireTokenViewController.m Adds correlation IDs + execution-flow logging around interactive/silent flows and surfaces execution-flow in UI output.
MSAL/IdentityCore Updates submodule commit to pick up IdentityCore changes needed for execution-flow logging.

kaisong1990 and others added 2 commits February 11, 2026 16:06
Co-authored-by: Juan Arias <juan-arias@users.noreply.github.com>
Co-authored-by: Juan Arias <juan-arias@users.noreply.github.com>
@kaisong1990 kaisong1990 enabled auto-merge (squash) February 12, 2026 01:06
@kaisong1990 kaisong1990 merged commit 4f42b51 into dev Feb 12, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants