-
Notifications
You must be signed in to change notification settings - Fork 157
[minor][feature] MSAL sample app: Add execution flow support for acquireTokenInteractive and acquireTokenSilent and update submodule #2870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -1 +1 @@ | |||
| Subproject commit f2466fa960ccfd8e500cab6f1d12b4127c6e63e1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not update CHANGELOG.md.
Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds execution-flow logging support to the MSAL sample app’s interactive and silent token acquisition flows (macOS + iOS) and updates the IdentityCore submodule.
Changes:
- Registered per-request correlation IDs and used
MSIDExecutionFlowLoggerto retrieve/flush execution flows after token operations. - Extended result/error rendering to include
executionFlowoutput. - Updated
MSAL/IdentityCoresubmodule reference.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| MSAL/test/app/mac/MSALAcquireTokenViewController.m | Adds correlation IDs + execution-flow logging around interactive/silent flows and surfaces execution-flow in UI output. |
| MSAL/test/app/ios/MSALTestAppAcquireTokenViewController.m | Adds correlation IDs + execution-flow logging around interactive/silent flows and surfaces execution-flow in UI output. |
| MSAL/IdentityCore | Updates submodule commit to pick up IdentityCore changes needed for execution-flow logging. |
Co-authored-by: Juan Arias <juan-arias@users.noreply.github.com>
Co-authored-by: Juan Arias <juan-arias@users.noreply.github.com>
PR Title Format
Required Format:
[Keyword1] [Keyword2]: Descriptionmajor,minor, orpatch(case-insensitive)feature,bugfix,engg, ortests(case-insensitive)Examples:
[MAJOR] [Feature]: new API[minor] [bugfix]: fix crash[PATCH] [tests]: add coverageProposed changes
Describe what this PR is trying to do.
Type of change
Risk
Additional information
AB#3407672