Fix /etc/init/docker.conf patch for Docker 1.10#98
Open
Conversation
Contributor
Contributor
Author
|
I did run in to #97, but waited about 5 minutes for the tar to complete, at which point the patch immediately failed. I don't have the exact log output anymore, but it was clear that the patch didn't apply to that version of docker.conf. It works after making this change. But in adaba9a John pins docker-engine to 1.9.1, which will make it necessary to undo this PR. |
Contributor
|
John's commit was cherry-picked into the stable branch as well, so I think the way forward for the master branch is to move the pin to 1.10, merge this PR and fix #97. John waited in excess of 10 minutes and nothing had happened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In docker 1.10, the Upstart docker.conf script has been changed slightly, making the patch fail in toil box.
Docker 1.10: https://github.com/docker/docker/blob/master/contrib/init/upstart/docker.conf
Docker 1.9.1: https://github.com/docker/docker/blob/v1.9.1/contrib/init/upstart/docker.conf
I don't know whether you should actually merge this or not, since you're considering pinning Docker at 1.9.1.