Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 7, 2026

Windows builds failing with ONNX Runtime linking errors (x86_64) and clang-cl incompatibility (aarch64). The fastembed dependency uses ONNX Runtime which doesn't build on Windows with MSVC toolchain.

Changes

Made fastembed optional

  • Added embeddings feature (default-enabled) to Cargo.toml
  • Conditional compilation in src/core/embedding.rs using #[cfg(feature = "embeddings")]
  • Windows builds run with --no-default-features in release workflow

Updated release workflow

  • Detects Windows targets via matrix.targets
  • Passes --no-default-features for Windows builds only
TARGETS="${{ join(matrix.targets, ' ') }}"
if [[ "$TARGETS" == *"windows"* ]]; then
  dist build ... --no-default-features > dist-manifest.json

Documentation

  • README notes Windows limitation: vector search unavailable, core functionality intact
  • Updated cargo install instructions for --no-default-features option

Impact

  • Windows binaries build and ship without embeddings/vector search
  • Linux/macOS retain full functionality with default features
  • No API changes for embeddings-enabled builds

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • parcel.pyke.io
    • Triggering command: /home/REDACTED/work/amdb/amdb/target/debug/build/ort-sys-1b7d35755358465a/build-script-build /home/REDACTED/work/amdb/amdb/target/debug/build/ort-sys-1b7d35755358465a/build-script-build -I /home/REDACTED/work/amdb/amdb/target/debug/build/onig_sys-42e93964e16e47ab/out -I oniguruma/src -w -DHAVE_UNISTD_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_TIME_H=1 -o /home/REDACTED/work/amdb/amdb/target/debug/build/onig_sys-42e93964e16e47ab/out/a445302c6d3dcb51-unicode_fold1_key.o -c e16e�� e16e47ab/out/a44-g e16e47ab/out cal/bin/as c_literal_escapecc c_std_workspace_-O0 k/amdb/amdb/targ-ffunction-sections stup/toolchains/-fdata-sections (dns block)
    • Triggering command: /home/REDACTED/work/amdb/.codeql-scratch/dbs/rust/working/target/debug/build/ort-sys-1b7d35755358465a/build-script-build /home/REDACTED/work/amdb/.codeql-scratch/dbs/rust/working/target/debug/build/ort-sys-1b7d35755358465a/build-script-build /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libaddr2line-ed0d1665fe189213.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libgimli-82f3ba019c4b6344.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libcfg_if-b8a9625d47e2e3c0.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/librustc_demangle-c04f2c50d366d1be.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libstd_detect-27563b08da68095e.rlib w-21c678f4b941a52a/build_script_build-21c678f4b941a52a.build_script_build.fef224/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libhashbrown-77a21fecb79c0678.rlib w-21c678f4b941a52a/build_script_build-21c678f4b941a52a.build_script_build.fef224/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/librustc_std_workspace_alloc-e793bd15fd20f0af.rlib w-21c678f4b941a52a/build_script_build-21c678f4b941a52a.d73zq7hlw22vrpyqclpwv3kpr/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libminiz_oxide-7aaf0cb5e2293c31.rlib /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-u�� /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libminiz_oxide-7aaf0cb5e2293c31.rlib 64-REDACTED-linux-gnu/lib/libstd-6455781cbbf0c25c.rlib 64-REDACTED-linux-gnu/lib/libpanic_unwind-9ea6681249c86daa.rlib 64-REDACTED-linux-gnu/lib/libobject-49a13cd1c17ee472.rlib 64-REDACTED-linux-gnu/lib/libmemchr-80c0d200aa1c5414.rlib 64-REDACTED-linux-gnu/lib/libaddr2line-ed0d1665fe189213.rlib 64-REDACTED-linux-gnu/lib/libgimli-82f3ba019c4b6344.rlib ld.2a973c4cf2f3687c-cgu.0.rcgu.o ld.2a973c4cf2f3687c-cgu.1.rcgu.o 7t5bb8xy2.rcgu.o (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits February 7, 2026 14:43
Co-authored-by: BETAER-08 <109971893+BETAER-08@users.noreply.github.com>
Co-authored-by: BETAER-08 <109971893+BETAER-08@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix release.yml for seamless v0.3.0 deployment Add Windows targets to release workflow Feb 7, 2026
Copilot AI requested a review from BETAER-08 February 7, 2026 14:46
Copilot AI and others added 4 commits February 7, 2026 15:04
Co-authored-by: BETAER-08 <109971893+BETAER-08@users.noreply.github.com>
Co-authored-by: BETAER-08 <109971893+BETAER-08@users.noreply.github.com>
Co-authored-by: BETAER-08 <109971893+BETAER-08@users.noreply.github.com>
Co-authored-by: BETAER-08 <109971893+BETAER-08@users.noreply.github.com>
Copilot AI changed the title Add Windows targets to release workflow Fix Windows builds by making fastembed optional Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants