Open
Conversation
Author
|
on another note, might also be good show how AppRuntime Options can be enabled inside LibNativeBridge, so people can easily enable debugger. |
bghgary
reviewed
Jan 21, 2025
Comment on lines
+16
to
+33
| void AppRuntime::RunEnvironmentTier(const char*) | ||
| { | ||
| auto globalContext = JSGlobalContextCreateInGroup(nullptr, nullptr); | ||
|
|
||
| if (@available(iOS 16.4, *)) { | ||
| JSGlobalContextSetInspectable(globalContext, m_options.EnableDebugger); | ||
| } | ||
|
|
||
| Napi::Env env = Napi::Attach(globalContext); | ||
|
|
||
| Run(env); | ||
|
|
||
| JSGlobalContextRelease(globalContext); | ||
|
|
||
| // Detach must come after JSGlobalContextRelease since it triggers finalizers which require env. | ||
| Napi::Detach(env); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Sorry for the slow response.
RunEnvironmentTier cannot be here as this function is intended to be JS environment specific. I think we need to add some platform specific macros to this code to ensure we don't call this function when it's not available. Availability.h has defines that we can check. Maybe also add a macro to disable this completedly in case someone is building against a version of JSC without this function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi, in order to run
JSGlobalContextSetInspectablethere needs to be check around it for iOS 16.4i noticed that
AppRuntime_iOS.mmwas callingRunEnvironmentTierinAppRuntime_JavaScriptCore.cpphowever because its inside a cpp file, @available syntax was not allowed.
ive duplicated the
RunEnvironmentTierfunction and moved it toAppRuntime_iOS.mmwhere @available check can run.