BAH-2763 | feature for sending prescription in sms#180
Open
kavitha-sundararajan wants to merge 10 commits intomasterfrom
Open
BAH-2763 | feature for sending prescription in sms#180kavitha-sundararajan wants to merge 10 commits intomasterfrom
kavitha-sundararajan wants to merge 10 commits intomasterfrom
Conversation
angshu
requested changes
Feb 7, 2023
bahmnicore-api/src/main/java/org/bahmni/module/bahmnicore/service/SharePrescriptionService.java
Outdated
Show resolved
Hide resolved
bahmnicore-api/src/main/java/org/bahmni/module/bahmnicore/service/BahmniDrugOrderService.java
Outdated
Show resolved
Hide resolved
...-api/src/main/java/org/bahmni/module/bahmnicore/service/impl/BahmniDrugOrderServiceImpl.java
Outdated
Show resolved
Hide resolved
...-api/src/main/java/org/bahmni/module/bahmnicore/service/impl/BahmniDrugOrderServiceImpl.java
Outdated
Show resolved
Hide resolved
bahmnicore-api/src/main/java/org/bahmni/module/bahmnicore/service/impl/SMSServiceImpl.java
Outdated
Show resolved
Hide resolved
bahmnicore-api/src/main/java/org/bahmni/module/bahmnicore/service/impl/SMSServiceImpl.java
Show resolved
Hide resolved
bahmnicore-api/src/main/java/org/bahmni/module/bahmnicore/service/impl/SMSServiceImpl.java
Outdated
Show resolved
Hide resolved
bahmnicore-api/src/main/java/org/bahmni/module/bahmnicore/service/impl/SMSServiceImpl.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/org/bahmni/module/bahmnicore/service/impl/SharePrescriptionServiceImpl.java
Show resolved
Hide resolved
angshu
reviewed
Feb 10, 2023
bahmnicore-api/src/main/java/org/bahmni/module/bahmnicore/service/BahmniDrugOrderService.java
Outdated
Show resolved
Hide resolved
bahmnicore-api/src/main/java/org/bahmni/module/bahmnicore/service/BahmniDrugOrderService.java
Show resolved
Hide resolved
bahmnicore-api/src/main/java/org/bahmni/module/bahmnicore/service/SMSService.java
Outdated
Show resolved
Hide resolved
...-api/src/main/java/org/bahmni/module/bahmnicore/service/impl/BahmniDrugOrderServiceImpl.java
Outdated
Show resolved
Hide resolved
bahmnicore-api/src/main/java/org/bahmni/module/bahmnicore/service/BahmniDrugOrderService.java
Outdated
Show resolved
Hide resolved
angshu
reviewed
Feb 10, 2023
bahmnicore-api/src/main/java/org/bahmni/module/bahmnicore/service/BahmniVisitService.java
Outdated
Show resolved
Hide resolved
…lding in an array" This reverts commit 047392e.
kymnguyen
reviewed
Aug 17, 2024
|
|
||
| public interface SMSService { | ||
|
|
||
| String getPrescriptionMessage(Locale locale, Date visitDate, Patient patient, Location location, List<String> providerList, String prescriptionDetail); |
There was a problem hiding this comment.
The method should have less than 3 params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.