Feat/update ban core api #652
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new /bal/cog endpoint to BAN-Core-API that enables requesting publication of a BAL (Base Adresse Locale) using a COG (INSEE code). The implementation follows the existing pattern of the /bal/text endpoint.
Key Changes:
- New POST endpoint
/bal/cogto handle BAL publication requests by COG - Enhanced error messages with more specific context
- Documentation updates for better clarity and corrections
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| apps/ban-core-api/src/index.ts | Adds new /bal/cog endpoint with COG-based BAL publication support, improves error messages, and adds type annotations |
| apps/ban-core-api/index.ts | Complete file deletion (likely consolidation or refactoring) |
| README.md | Documentation improvements including typo fixes, formatting cleanup, and new data initialization guide |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ilot) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mise à jour de BAN-Core-API dans le but d'ajouter un endpoint permettant de demander la publication d'une BAL à partir de son code INSEE. (Seul le endpoint est présent. Son exécution par ID-Fix sera effectuée dans une PR séparée)