CaptureProvider._processVoiceCommandBytes - Null check crash

[aaravgarg]

Summary

• Add null check for _recordingDevice before accessing .id in _processVoiceCommandBytes
• Prevents crash when device disconnects during voice command processing

Crash Stats

• Events: 111 (iOS) + 56 (Android)
• Users affected: 84 (iOS) + 33 (Android)
• Crashlytics (iOS): View in Console
• Crashlytics (Android): View in Console

Test plan

• Verify voice commands still work when device is connected
• Test disconnecting device during voice command (should log warning, not crash)

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request addresses a crash in _processVoiceCommandBytes by adding a null check for _recordingDevice before it's accessed. This is a good and necessary fix. I've suggested a small improvement to make the code even more robust by capturing _recordingDevice in a local variable. This avoids using the null-assertion operator (!) and makes the code safer against potential race conditions.

[gemini-code-assist]

While adding the null check is a good fix for the crash, it's better to avoid using the null-assertion operator (!) on _recordingDevice. Since _recordingDevice is a mutable class field, the compiler can't guarantee it won't be null after the check, especially with await calls.

A safer approach is to capture _recordingDevice in a local variable. This allows for type promotion and removes the need for the ! operator, making the code more robust against potential race conditions.

    final recordingDevice = _recordingDevice;
    if (recordingDevice == null) {
      Logger.debug("_processVoiceCommandBytes: recording device is null, skipping");
      return;
    }

    BleAudioCodec codec = await _getAudioCodec(recordingDevice.id);

[mdmohsin7]

closed in #4628

[github-actions]

Hey @aaravgarg 👋

Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request.

After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:

• Project standards — Ensuring consistency across the codebase
• User needs — Making sure changes align with what our users need
• Code best practices — Maintaining code quality and maintainability
• Project direction — Keeping aligned with our roadmap and vision

Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out.

Thank you for being part of the Omi community! 💜