ForegroundServiceDidNotStopInTimeException crash#4549
Conversation
Prevent errors during recorder cleanup from blocking service stop, which can cause ForegroundServiceDidNotStopInTimeException on Android. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
fixed in #4630 |
|
Hey @aaravgarg 👋 Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request. After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out. Thank you for being part of the Omi community! 💜 |
Summary
stop()in try-catch during both service stop and watchdog retirestopSelf(), which causesForegroundServiceDidNotStopInTimeExceptionon AndroidstopSelf()is always called even if recorder stop failsCrash Stats
Test plan
🤖 Generated with Claude Code