Add custom small icon configuration #3
Conversation
arnaud-roland
requested review from
ThomasMengelatte and
abarisain
as code owners
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (props.iosApiKey) { | ||
| infoPlist.BatchAPIKey = props.iosApiKey; | ||
| } else { | ||
| console.error("⚠️ [Batch] `iosApiKey` cannot be null or undefined."); |
There was a problem hiding this comment.
The new guard only writes BatchAPIKey when iosApiKey is truthy and otherwise just logs. If a project already contains an Info.plist with a previous Batch key and a developer later removes the key from app.json and reruns expo prebuild against the existing iOS directory, this branch now leaves the old BatchAPIKey untouched, so the app still uses the stale credential even though it has been removed from the config. Prior code overwrote the value (even with empty/undefined), so the configuration no longer stays in sync.
Useful? React with 👍 / 👎.
| if (props.androidApiKey) { | ||
| AndroidConfig.Strings.setStringItem( | ||
| [ | ||
| { | ||
| $: { |
There was a problem hiding this comment.
Similarly, the strings.xml update now runs only when androidApiKey is truthy; if the key is removed from app.json but an existing Android project already has BATCH_API_KEY from a prior build, rerunning prebuild will skip setStringItem and leave the old key in place. That makes it impossible to clear or change the Batch API key through configuration alone, causing the native project to continue using stale credentials.
Useful? React with 👍 / 👎.
2 participants
androidSmallIconResourceIdandandroidNotificationsColorconfiguration options for enhanced notification customization.