This repository was archived by the owner on Aug 15, 2022. It is now read-only.
Set UDP Client socket to disregard ICMP errors and forcibly disconnect.#315
Open
phalasz wants to merge 1 commit intoBeardedManStudios:developfrom
Open
Set UDP Client socket to disregard ICMP errors and forcibly disconnect.#315phalasz wants to merge 1 commit intoBeardedManStudios:developfrom
phalasz wants to merge 1 commit intoBeardedManStudios:developfrom
Conversation
phalasz
force-pushed
the
fix/readthread-exception-on-connect
branch
from
d6e020d to
2d3aae7
Compare
phalasz
force-pushed
the
fix/readthread-exception-on-connect
branch
from
2d3aae7 to
5c4f9d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a discussion on discord it was discovered that the ReadThread could encounter a Connection Reset Socket exception while trying to connect to a server that is not running.
The expected behaviour here would be to trigger a connectAttempFailed event, but the exception will close the socket and the loop checking for the connection attempts will be terminated early without firing the event.
Thank you for @andreivreja for finding the possible solution.