Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Type II compensator building block and updates the USB Source Measure Unit (SMU) example hardware/simulation artifacts to match new loop-compensation and stability tuning.
Changes:
- Introduces
CompensatorType2(Type II compensator) as an importable schematic-backed control circuit. - Updates the SMU example to use the new compensator and changes the gate-drive resistor implementation (now a 10× series split).
- Refreshes KiCad + SVGPCB + LTSpice simulation files to reflect the tuned analog control/power stage.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/test_usb_source_measure.py | Updates driver gate resistance/power assumptions and increases the series-split resistor count. |
| examples/UsbSourceMeasure/analysis/power_stage.asc | Updates LTSpice power-stage model for new tuning/loop analysis setup. |
| examples/UsbSourceMeasure/UsbSourceMeasure.svgpcb.js | Updates PCB placement/netlist to match schematic changes (compensator + resistor array changes). |
| examples/UsbSourceMeasure/SourceMeasureControl.kicad_sch | Switches integrator block to #CompensatorType2(...) and adjusts filter cutoff parameters + notes. |
| edg/abstract_parts/resources/CompensatorType2.kicad_sch | Adds the KiCad schematic resource used by the new compensator block import. |
| edg/abstract_parts/init.py | Exposes CompensatorType2 from abstract_parts. |
| edg/abstract_parts/ControlCircuits.py | Implements the new CompensatorType2 block and KiCad import/conversions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| SYMATTR Value 150 | ||
| SYMBOL cap 992 736 R0 | ||
| SYMATTR InstName C3 | ||
| SYMATTR Value 100� |
There was a problem hiding this comment.
SYMATTR Value 100� contains a replacement/invalid character (likely intended to be a micro prefix). LTspice value fields are typically ASCII (eg 100u), and this character can cause parsing issues depending on editor/encoding. Replace it with an unambiguous ASCII value.
Suggested change
| SYMATTR Value 100� | |
| SYMATTR Value 100u |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tuning and tested with the actual hardare.