Merged
Conversation
Owner
|
Yes, using the Container Registry for the images would be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised yesterday this should fix the issues with older versions of Raspbian. I tested building in on my RPi Zero using Bookworm, my Pi 4 using Bookworm (32-bit and 64-bit) and Trixie (just 64 bit). I also tested a fallback to Docker which I mentioned in the troubleshooting guide (Docker should be a suitable fallback since Podman and Docker a nearly interchangeable). This is also the reason why there are more --platforms now, since Docker seemed to default to linux/arm/v8 (when pulling images this still uses arm/v7 images) on therefore requiring additional handling to get the dynamic selection working.
Trixie should have a sufficiently recent version of podman to not need the --platform argument, but I guess it is still better to include it and not need it than the other way round.
As it takes a lot of time to build the image (especially on the RPi Zero), I would suggest implementing a Github Action that builds the file for all the architectures and serves them via the Github Container Registry. This would simplify installation drastically as well.
If you want I can take a look at that as well, though I have no idea on how to do that in a Github Runner (technically one could also manually push to the GCR, but I think this is not as elegant).