Add COLLECT_OTEL_*_PORT

[paweljw]

For OTel listeners, but I'm thinking forwards - make it flexible enough to be re-used in the future. So not expose_otel bool.

[curusarn]

Since we're openning these ports via helm chart config - should the same value be automatically used and picked up by vector to listen on the same ports?

How many steps do I need to listen on port of my choice?

• expose them here via helm config
• then configure the same ports in UI?

I'd love to make this a single step.

E.g. set an ENV and automatically listen on the port if the env is set (?)

[paweljw]

@curusarn fair points. We haven't added configuring ports to the UI. Do you want to do that (and pass them in through ENV to Vector)?

[paweljw]

We could do like OTEL_GRPC_PORT and OTEL_HTTP_PORT in all of install.sh, chart (exposed as otel_grpc_port and otel_http_port), and Vector, with Vector falling back to defaults

[curusarn]

@curusarn fair points. We haven't added configuring ports to the UI. Do you want to do that (and pass them in through ENV to Vector)?

I feel strongly that they should be configured from a single place. Coordinating two places seems extra.

I thought is needs to be from helm chart values so that they are known at deploy time.
-> set something like "collectOtel.grpcPort", "collectOtel.httpPort" in helm chart values
-> this sets ENV in the container (easier if possible)
-> we either condition on that in Vector config or send it up to telemetry and generate appropriate vector config with otel source
-> we use the set ports automatically

I'm assuming we can't really set port in UI because the ports need to be set on the DaemonSet during deploy time. Or is there a way we can control this from UI fully?

[paweljw]

I can't think of one, they need to be known at deploy time. Your plan sounds good, I'll do that 👍

[curusarn]

Thank you! 🙏

[paweljw]

@curusarn this should be much simpler - just take the values and forward into the container. The rest of the support goes into Telemetry.

[curusarn]

Looks great, thank you!