Fix: delete quote prefix that is right after quoted list #3023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for calva-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jramosg
changed the title
Adjust the condition to determine if the cursor is right after a quote
prefix. This change allows for the deletion of the quote when the cursor
is positioned between the quote and an opening parenthesis, improving
the editing experience.
Fixes Delete Operations with Single Quote (')
Fixes BetterThanTomorrow#3020
This commit introduces tests to verify the deletion of quote prefixes from quoted lists, nested quoted lists, and quoted vectors. These tests ensure that the backspace and deleteForward functions handle quote prefixes correctly, addressing issue BetterThanTomorrow#3020.
…right after list opening
Simplify the parameters for the analyzePrefixDeletionContext function by removing the nextToken argument. This change improves code clarity and maintains the functionality of prefix deletion during structural backspace operations.
jramosg
force-pushed
the
fix/delete-quote-prefix-from-right-after-quoted-list
branch
from
e335343 to
cb4e8f7
Compare
jramosg
deleted the
fix/delete-quote-prefix-from-right-after-quoted-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
'could not be delete when there was after a opening list form:'('(1 2 3))Fixes #3020
My Calva PR Checklist
I have:
devbranch. (Or have specific reasons to target some other branch.)published. (Sorry for the nagging.)[Unreleased]entry inCHANGELOG.md, linking the issue(s) that the PR is addressing.npm run prettier-format)npm run eslintbefore creating your PR, or runnpm run eslint-watchto eslint as you go).