Error slurp backward commented expresssions #3026
Merged
+34
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
When attempting to perform a "slurp backward" operation with a previous ignored/commented expression (using
#_), the operation would produce incorrect results and throw and error.forwardSexpmethod intoker-cursorwas treating#_as a single token instead of treating#_(form)as a unified s-expression.Now
forwardSexpalways moves past the complete ignored form#_(form)as a single unit:backwardSexpwould position the cursor at the form being ignored rather than at the#_marker itself when slurping.backwardSexpto find the previous form, we now check if it's preceded by an#_ignore markerFixes #3025
My Calva PR Checklist
I have:
devbranch. (Or have specific reasons to target some other branch.)published. (Sorry for the nagging.)[Unreleased]entry inCHANGELOG.md, linking the issue(s) that the PR is addressing.npm run prettier-format)npm run eslintbefore creating your PR, or runnpm run eslint-watchto eslint as you go).