Fixes failing PowerPC unit tests#1603
Open
bmourad01 wants to merge 1 commit intoBinaryAnalysisPlatform:masterfrom
Open
Fixes failing PowerPC unit tests#1603bmourad01 wants to merge 1 commit intoBinaryAnalysisPlatform:masterfrom
bmourad01 wants to merge 1 commit intoBinaryAnalysisPlatform:masterfrom
Conversation
Contributor
Author
|
cc @gitoleg The git history says you wrote all of this so I wanted to make sure that these changes make sense. I assume at one point the tests were passing. |
Contributor
|
looks reasonable! But I have no idea why we didn't see this fail before |
bmourad01
force-pushed
the
fix-ppc-unit-tests
branch
from
e233074 to
6ee00e7
Compare
Contributor
|
@bmourad01 could you please update the PR to trigger CI again? The CI log expired and it's unclear what was the error. |
bmourad01
force-pushed
the
fix-ppc-unit-tests
branch
from
6ee00e7 to
8d68bb0
Compare
Contributor
Author
|
CI currently has this error for all but one of the jobs: |
bmourad01
force-pushed
the
fix-ppc-unit-tests
branch
from
8d68bb0 to
6258b1b
Compare
Also includes a fix for `ldu`. The manual says that the immediate is sign-extended.
bmourad01
force-pushed
the
fix-ppc-unit-tests
branch
from
6258b1b to
16cf14d
Compare
Contributor
Author
|
It seems there's one failing functional test: I'll try to figure out what's going on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failing tests were all related to load/store instruction encodings. It seems that they accept a sign-extended 16-bit immediate offset in these cases, and the sign extension wasn't being performed by the lifter.