-
Notifications
You must be signed in to change notification settings - Fork 0
Update Maven repositories to judo.technology (JNG-6328) #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughConsolidates Nexus server IDs and secrets across GitHub Actions workflows, removes Maven mirror configurations, normalizes branch filter formatting, updates JDK distribution syntax, adjusts Eclipse project metadata, and revises the POM’s distributionManagement and repositories to new Judong repository endpoints. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pom.xml (1)
1072-1083: Clarify repository architecture: upstream vs. regular.The POM now defines two distinct repository paths:
maven-judong-upstreamfor distribution (deployment)maven-judongfor dependency resolutionThis suggests a repository architecture where artifacts are deployed to
-upstreamand consumed from the regular path. Please document this architecture choice, as it's not immediately obvious and could confuse maintainers.Additionally, verify the repository URL is accessible:
#!/bin/bash # Test both repository URLs echo "=== Testing dependency resolution repository ===" curl -I -s https://repository.judo.technology/repository/maven-judong/ | head -n 1 echo -e "\n=== Testing distribution repository ===" curl -I -s https://repository.judo.technology/repository/maven-judong-upstream/ | head -n 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (8)
.github/workflows/build-dependabot.yml(2 hunks).github/workflows/build.yml(4 hunks).github/workflows/bump-version.yml(2 hunks).github/workflows/create-release-on-master.yml(2 hunks).github/workflows/release.yml(1 hunks)judo-runtime-core-guice-testkit/.classpath(1 hunks)judo-runtime-core-guice-testkit/.project(1 hunks)pom.xml(2 hunks)
🔇 Additional comments (12)
judo-runtime-core-guice-testkit/.classpath (1)
39-55: LGTM! Standard Eclipse/Maven integration metadata.The added attributes configure Eclipse's Maven integration (m2e) to properly handle annotation-generated sources, which is a standard IDE configuration practice.
.github/workflows/create-release-on-master.yml (2)
5-5: Approved: Branch filter formatting normalized.
34-54: Confirm repository secrets and verify server IDs across workflows
- pom.xml defines
<id>judong</id>(line 1074) and<id>judong-distribution</id>(lines 874, 879), matching the workflow.- These IDs appear in workflows: bump-version.yml, build-dependabot.yml, release.yml, build.yml, and create-release-on-master.yml.
- Ensure
JUDONG_REPOSITORY_USERandJUDONG_REPOSITORY_PASSWORDare configured in the repo’s Secrets settings for all workflows..github/workflows/build-dependabot.yml (2)
5-5: Approved: Consistent branch filter formatting.
43-63: Credentials updated consistently with other workflows.The server configuration matches the pattern established in other workflow files, using the new repository-based credentials.
.github/workflows/build.yml (3)
5-7: Approved: Branch filter formatting normalized.
40-40: Approved: Distribution syntax normalized.Both quoted and unquoted forms are acceptable in YAML for this parameter.
52-72: Server configuration updated consistently.The Maven settings now use the consolidated server IDs and repository-based credentials, matching the changes in other workflow files and pom.xml.
.github/workflows/release.yml (1)
49-64: Maven settings updated with new repository configuration.The removal of the mirrors block means Maven will resolve dependencies directly from the repositories defined in pom.xml rather than through a mirror. Ensure this change was intentional and that the new repository URLs in pom.xml are properly configured to serve all required dependencies.
Based on learnings: If removing mirrors impacts build times or dependency availability, consider documenting the expected behavior change in the PR description.
.github/workflows/bump-version.yml (2)
49-64: All workflows now consistently use JUDONG_REPOSITORY secrets
No remainingJUDONG_NEXUS_*references; every workflow file usesJUDONG_REPOSITORY_USER/JUDONG_REPOSITORY_PASSWORD.
10-10: YAML unquoted “Auto” remains a string. UnquotedAutoisn’t a boolean literal in GitHub Actions YAML, so the default type and behavior are unchanged; the comparison at line 80 still works.Likely an incorrect or invalid review comment.
pom.xml (1)
872-883: Distribution repository URL is reachable (HTTP 200) and server IDjudong-distributionmatches all workflows.
JNG-6328 Update Maven repositories to repository.judo.technology