Skip to content

Conversation

@robertcsakany
Copy link
Member

@robertcsakany robertcsakany commented Oct 14, 2025

JNG-6328 Update Maven repositories to repository.judo.technology

@coderabbitai
Copy link

coderabbitai bot commented Oct 14, 2025

Walkthrough

Consolidates Nexus server IDs and secrets across GitHub Actions workflows, removes Maven mirror configurations, normalizes branch filter formatting, updates JDK distribution syntax, adjusts Eclipse project metadata, and revises the POM’s distributionManagement and repositories to new Judong repository endpoints.

Changes

Cohort / File(s) Summary of Changes
GitHub Actions: Build/PR/Release workflows
.github/workflows/build.yml, .github/workflows/build-dependabot.yml, .github/workflows/create-release-on-master.yml, .github/workflows/release.yml, .github/workflows/bump-version.yml
Normalized branch filters; removed Maven mirrors block; renamed server IDs from judong-nexus-mirrorjudong and judong-nexus-distributionjudong-distribution; switched secrets from JUDONG_NEXUS_USERNAME/PASSWORD to JUDONG_REPOSITORY_USER/PASSWORD; minor formatting tweaks (e.g., unquoted zulu).
Maven POM: Distribution and repositories
pom.xml
distributionManagement IDs judong-nexus-distributionjudong-distribution; URLs switched to https://repository.judo.technology/repository/maven-judong-upstream/; added repositories entry judong at https://repository.judo.technology/repository/maven-judong/ (releases enabled, snapshots disabled).
Eclipse project metadata
judo-runtime-core-guice-testkit/.classpath, judo-runtime-core-guice-testkit/.project
.classpath: added attributes maven.pomderived=true, ignore_optional_problems=true, m2e-apt=true to generated sources entries. .project: updated a filter <id> value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my whiskers at repos anew,
Mirrors gone—clean paths to hop through.
Secrets renamed, credentials neat,
Pipelines drum a steady beat.
In fields of YAML I proudly thump—
Judong burrows, upstream jump! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the main change of updating Maven repository URLs to judo.technology, aligning with modifications in both the pom.xml and workflow files while also including the ticket reference. It is concise, clear, and focused on the primary change without unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The pull request description clearly states that Maven repository URLs are being updated to repository.judo.technology, which directly corresponds to the changes observed in the workflow and POM files; it is specific and on-topic. It references the correct JIRA ticket and summarizes the scope of the modifications. Therefore, it meets the criteria for a passing description check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/JNG-6328_ChangeMavenRepositories

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pom.xml (1)

1072-1083: Clarify repository architecture: upstream vs. regular.

The POM now defines two distinct repository paths:

  • maven-judong-upstream for distribution (deployment)
  • maven-judong for dependency resolution

This suggests a repository architecture where artifacts are deployed to -upstream and consumed from the regular path. Please document this architecture choice, as it's not immediately obvious and could confuse maintainers.

Additionally, verify the repository URL is accessible:

#!/bin/bash
# Test both repository URLs
echo "=== Testing dependency resolution repository ==="
curl -I -s https://repository.judo.technology/repository/maven-judong/ | head -n 1

echo -e "\n=== Testing distribution repository ==="
curl -I -s https://repository.judo.technology/repository/maven-judong-upstream/ | head -n 1
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 845f294 and b492972.

📒 Files selected for processing (8)
  • .github/workflows/build-dependabot.yml (2 hunks)
  • .github/workflows/build.yml (4 hunks)
  • .github/workflows/bump-version.yml (2 hunks)
  • .github/workflows/create-release-on-master.yml (2 hunks)
  • .github/workflows/release.yml (1 hunks)
  • judo-runtime-core-guice-testkit/.classpath (1 hunks)
  • judo-runtime-core-guice-testkit/.project (1 hunks)
  • pom.xml (2 hunks)
🔇 Additional comments (12)
judo-runtime-core-guice-testkit/.classpath (1)

39-55: LGTM! Standard Eclipse/Maven integration metadata.

The added attributes configure Eclipse's Maven integration (m2e) to properly handle annotation-generated sources, which is a standard IDE configuration practice.

.github/workflows/create-release-on-master.yml (2)

5-5: Approved: Branch filter formatting normalized.


34-54: Confirm repository secrets and verify server IDs across workflows

  • pom.xml defines <id>judong</id> (line 1074) and <id>judong-distribution</id> (lines 874, 879), matching the workflow.
  • These IDs appear in workflows: bump-version.yml, build-dependabot.yml, release.yml, build.yml, and create-release-on-master.yml.
  • Ensure JUDONG_REPOSITORY_USER and JUDONG_REPOSITORY_PASSWORD are configured in the repo’s Secrets settings for all workflows.
.github/workflows/build-dependabot.yml (2)

5-5: Approved: Consistent branch filter formatting.


43-63: Credentials updated consistently with other workflows.

The server configuration matches the pattern established in other workflow files, using the new repository-based credentials.

.github/workflows/build.yml (3)

5-7: Approved: Branch filter formatting normalized.


40-40: Approved: Distribution syntax normalized.

Both quoted and unquoted forms are acceptable in YAML for this parameter.


52-72: Server configuration updated consistently.

The Maven settings now use the consolidated server IDs and repository-based credentials, matching the changes in other workflow files and pom.xml.

.github/workflows/release.yml (1)

49-64: Maven settings updated with new repository configuration.

The removal of the mirrors block means Maven will resolve dependencies directly from the repositories defined in pom.xml rather than through a mirror. Ensure this change was intentional and that the new repository URLs in pom.xml are properly configured to serve all required dependencies.

Based on learnings: If removing mirrors impacts build times or dependency availability, consider documenting the expected behavior change in the PR description.

.github/workflows/bump-version.yml (2)

49-64: All workflows now consistently use JUDONG_REPOSITORY secrets
No remaining JUDONG_NEXUS_* references; every workflow file uses JUDONG_REPOSITORY_USER/JUDONG_REPOSITORY_PASSWORD.


10-10: YAML unquoted “Auto” remains a string. Unquoted Auto isn’t a boolean literal in GitHub Actions YAML, so the default type and behavior are unchanged; the comparison at line 80 still works.

Likely an incorrect or invalid review comment.

pom.xml (1)

872-883: Distribution repository URL is reachable (HTTP 200) and server ID judong-distribution matches all workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant