Update Maven repositories to judo.technology (JNG-6328)#562
Update Maven repositories to judo.technology (JNG-6328)#562robertcsakany wants to merge 1 commit intodevelopfrom
Conversation
WalkthroughRenamed Maven server IDs and updated credentials across multiple GitHub Actions workflows, removed mirror configurations, and adjusted POM distributionManagement to new repository endpoints. Added a repositories section to POM with the new Judong repository. No build logic or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
55-63: Aligned with POM; minor checkLooks good. If judong and judong-distribution use different credentials, consider separate secrets; if same account, current setup is fine.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (6)
.github/workflows/build-dependabot.yml(1 hunks).github/workflows/build.yml(1 hunks).github/workflows/bump-version.yml(1 hunks).github/workflows/create-release-on-master.yml(1 hunks).github/workflows/release.yml(1 hunks)pom.xml(5 hunks)
🔇 Additional comments (6)
.github/workflows/create-release-on-master.yml (1)
40-48: Consistent migration to new repo IDsIDs and credentials updated consistently. Nothing else to change here.
.github/workflows/bump-version.yml (1)
55-63: OK for a non-deploy workflowUsing only judong/judong-distribution servers (no OSSRH) is fine here since this job doesn’t deploy to Central.
.github/workflows/build-dependabot.yml (1)
49-57: Dependabot build: IDs/secrets updated correctlyMatches the new POM/server scheme. The dependabot-only guard keeps secrets safe.
pom.xml (2)
367-375: DistributionManagement updated; confirm upstream usage for both release/snapshotIDs are correct. Using the same upstream URL for snapshotRepository and repository is OK if the upstream handles both. Please confirm that the upstream repo accepts snapshots on this path; otherwise, separate snapshot path may be required.
579-590: New repository entry looks correct; snapshots disabledJudong repo added with releases enabled, snapshots disabled. Confirm you don’t need snapshot dependencies from judong; if you do, add a snapshots-enabled repo or a profile for snapshots.
.github/workflows/build.yml (1)
57-65: Server IDs match POM and no stale endpoints remain
build.yml entries for judong and judong-distribution align with POM repository IDs and URLs; confirm JUDONG_REPOSITORY_USER and JUDONG_REPOSITORY_PASSWORD secrets are configured in repo/org settings and scoped to this repo’s runners.
JNG-6328 Update Maven repositories to repository.judo.technology